You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by glisignoli <gi...@git.apache.org> on 2017/09/11 02:47:56 UTC
[GitHub] nifi pull request #2141: NIFI-4374 Added buffer size to FTP connections
GitHub user glisignoli opened a pull request:
https://github.com/apache/nifi/pull/2141
NIFI-4374 Added buffer size to FTP connections
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/glisignoli/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2141.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2141
----
commit 12476bf01fe9e16e587128b7739ac1d43eaaf9b1
Author: Gino Lisignoli <gl...@gmail.com>
Date: 2017-09-10T22:49:47Z
Added buffer size to FTP connections
----
---
[GitHub] nifi pull request #2141: NIFI-4374 Added buffer size to FTP connections
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2141
---
[GitHub] nifi issue #2141: NIFI-4374 Added buffer size to FTP connections
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2141
@glisignoli LGTM +1, thanks again for trying to improve the FTP processors performance. Nice work!
---
[GitHub] nifi issue #2141: NIFI-4374 Added buffer size to FTP connections
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2141
@glisignoli Excuse me, I didn't notice that you've already created a JIRA and PR. Thanks for your contribution! I closed mine. Yours look good, running local tests just in case..
---