You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/03 19:41:13 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #841: Add
JMS extension
jamesnetherton opened a new pull request #841: Add JMS extension
URL: https://github.com/apache/camel-quarkus/pull/841
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#841: Add JMS extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #841: Add JMS extension
URL: https://github.com/apache/camel-quarkus/pull/841#discussion_r387304810
##########
File path: extensions/paho/deployment/src/main/java/org/apache/camel/quarkus/component/paho/deployment/PahoProcessor.java
##########
@@ -39,7 +41,8 @@
private static final List<Class<?>> PAHO_REFLECTIVE_CLASSES = Arrays.asList(
JSR47Logger.class,
TCPNetworkModuleFactory.class,
- SSLNetworkModuleFactory.class);
+ SSLNetworkModuleFactory.class,
+ PahoConfiguration.class);
Review comment:
Looks suspicious that we need to add `PahoConfiguration[ as it seems correct on [camel side](https://github.com/apache/camel/blob/release/3.1.0/components/camel-paho/src/main/java/org/apache/camel/component/paho/PahoComponent.java#L55-L58), wonder if this is a regression either on camel or camel-quarkus side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton merged pull request #841: Add JMS
extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #841: Add JMS extension
URL: https://github.com/apache/camel-quarkus/pull/841
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on issue #841: Add JMS
extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #841: Add JMS extension
URL: https://github.com/apache/camel-quarkus/pull/841#issuecomment-594382927
@ppalaga Latest commit addresses your review comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services