You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "ZeRego (via GitHub)" <gi...@apache.org> on 2025/04/08 14:20:32 UTC

[I] [Bug] Pie label position doesn't update correctly when switching between outside and inside [echarts]

ZeRego opened a new issue, #20905:
URL: https://github.com/apache/echarts/issues/20905

   ### Version
   
   5.5.1
   
   ### Link to Minimal Reproduction
   
   https://jsfiddle.net/sd807pz3/2/
   
   ### Steps to Reproduce
   
   1. use api `setOption` to switch pie label between inside and outside
   
   ![Image](https://github.com/user-attachments/assets/05caa1ec-cdff-47da-a58b-180aeed870b0)
   
   ### Current Behavior
   
   Line from outside label doesn't disappear.
   
   ### Expected Behavior
   
   Line from outside label disappears.
   
   ### Environment
   
   ```markdown
   - OS:
   - Browser:
   - Framework:
   ```
   
   ### Any additional comments?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [I] [Bug] Pie label position doesn't update correctly when switching between outside and inside [echarts]

Posted by "ZeRego (via GitHub)" <gi...@apache.org>.
ZeRego commented on issue #20905:
URL: https://github.com/apache/echarts/issues/20905#issuecomment-2786633066

   Might be related to https://github.com/apache/echarts/issues/20904


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [I] [Bug] Pie label position doesn't update correctly when switching between outside and inside [echarts]

Posted by "gioneves (via GitHub)" <gi...@apache.org>.
gioneves commented on issue #20905:
URL: https://github.com/apache/echarts/issues/20905#issuecomment-2787897141

   It's not a bug. Just use the [`labelLine`](https://echarts.apache.org/en/option.html#series-pie.labelLine) property:
   
     
       document.getElementById(“get-data-2”).addEventListener(“click”, () => {
         chart.setOption(
           {
             series: [
               {
                 type: “pie”,
                 data: [
                   {
                     name: “2017-01”,
                     value: 94,
                     label: {
                       show: true,
                       position: “inside”
                     },
                     labelLine: {
                       show: false // <------ here
                     }
                   },
                 ],
               },
             ],
           }


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [I] [Bug] Pie label position doesn't update correctly when switching between outside and inside [echarts]

Posted by "gioneves (via GitHub)" <gi...@apache.org>.
gioneves commented on issue #20905:
URL: https://github.com/apache/echarts/issues/20905#issuecomment-2791120827

   @ZeRego Yes, exactly. If label.position = "inside", it wouldn't make sense to have a line pointing to the label, since it's already positioned inside and doesn't need an external indicator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [I] [Bug] Pie label position doesn't update correctly when switching between outside and inside [echarts]

Posted by "ZeRego (via GitHub)" <gi...@apache.org>.
ZeRego commented on issue #20905:
URL: https://github.com/apache/echarts/issues/20905#issuecomment-2788818123

   @gioneves Thanks for pointing out the `labelLine` property. But isn't it inconsistent behaviour that updating the label.position might impact the `labelLine` based on the value? If 'outside' sets `labelLine.show=true` I would expect 'inside' to set `labelLine.show=false`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [I] [Bug] Pie label position doesn't update correctly when switching between outside and inside [echarts]

Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart closed issue #20905: [Bug] Pie label position doesn't update correctly when switching between outside and inside
URL: https://github.com/apache/echarts/issues/20905


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org