You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/06/01 18:32:52 UTC

[Impala-ASF-CR] IMPALA-14838: Count open deferred RPC intervals

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24375 )

Change subject: IMPALA-14838: Count open deferred RPC intervals
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24375/2/be/src/runtime/krpc-data-stream-recvr.cc
File be/src/runtime/krpc-data-stream-recvr.cc:

http://gerrit.cloudera.org:8080/#/c/24375/2/be/src/runtime/krpc-data-stream-recvr.cc@56
PS2, Line 56: DeferredRpcsTimeTracker
Did you look at ConcurrentTimerCounter? It is backed by ConcurrentStopWatch which expects start/stop calls from multiple threads and measures time when not all start has a stop pair.

Interestingly I don't see it used anywhere in code besides tests.



-- 
To view, visit http://gerrit.cloudera.org:8080/24375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5efe8016b268e3707a2b7b99c488de69ccdad8e6
Gerrit-Change-Number: 24375
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 18:32:52 +0000
Gerrit-HasComments: Yes