You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/05/24 12:38:50 UTC
Re: Review Request 67270: Fixed various issues in libprocess example.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/
-----------------------------------------------------------
(Updated May 24, 2018, 12:38 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Fix various other issues.
Summary (updated)
-----------------
Fixed various issues in libprocess example.
Repository: mesos
Description (updated)
-------
* Added the mandatory help string argument to calls
to 'route()', failing compilation.
* The response returned from the '/vars' endpoint had
its 'type' field set to 'NONE', causing indefinite
hanging when trying to access the endpoint. Switched
to a constructor for OK that implicitly sets that field.
* Removed a stray pid variable in main.
Diffs (updated)
-----
3rdparty/libprocess/examples/example.cpp a97665ee6b75c5b31397b5a10002fa23a7fe370a
Diff: https://reviews.apache.org/r/67270/diff/2/
Changes: https://reviews.apache.org/r/67270/diff/1-2/
Testing
-------
Compiled the `example.cpp` file.
Thanks,
Benno Evers
Re: Review Request 67270: Fixed compilation issues in libprocess
example.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/#review203974
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On May 24, 2018, 3:33 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67270/
> -----------------------------------------------------------
>
> (Updated May 24, 2018, 3:33 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> * Added the mandatory help string argument to calls
> to 'route()', failing compilation.
>
> * The response returned from the '/vars' endpoint had
> its 'type' field set to 'NONE', causing indefinite
> hanging when trying to access the endpoint. Switched
> to a constructor for OK that implicitly sets that field.
>
> * Removed a stray pid variable in main.
>
> * Added http:: namespace to disambiguate calls to 'post()'.
>
> * Commented out example code that commits instant
> self-termination by default.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/examples/example.cpp 8c507aefa050543dfa6184626c494918c96d35e7
>
>
> Diff: https://reviews.apache.org/r/67270/diff/4/
>
>
> Testing
> -------
>
> Compiled the `example.cpp` file.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67270: Fixed compilation issues in libprocess
example.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/
-----------------------------------------------------------
(Updated May 29, 2018, 1:46 p.m.)
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description (updated)
-------
* Added the mandatory help string argument to calls
to 'route()', failing compilation.
* The response returned from the '/vars' endpoint had
its 'type' field set to 'NONE', causing indefinite
hanging when trying to access the endpoint. Switched
to a constructor for OK that implicitly sets that field.
* Removed a stray pid variable in main.
* Added http:: namespace to disambiguate calls to 'post()'.
* Added a name to the example process.
* Commented out example code that commits instant
self-termination by default.
Diffs (updated)
-----
3rdparty/libprocess/examples/example.cpp a97665ee6b75c5b31397b5a10002fa23a7fe370a
Diff: https://reviews.apache.org/r/67270/diff/5/
Changes: https://reviews.apache.org/r/67270/diff/4-5/
Testing
-------
Compiled the `example.cpp` file.
Thanks,
Benno Evers
Re: Review Request 67270: Fixed compilation issues in libprocess
example.
Posted by Benno Evers <be...@mesosphere.com>.
> On May 25, 2018, 3:37 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/examples/example.cpp
> > Line 106 (original), 98 (patched)
> > <https://reviews.apache.org/r/67270/diff/4/?file=2028088#file2028088line113>
> >
> > If you add this and the one below you should remove the `using` decl for `process::http` on top.
> >
> > Or just leave this as it was for now.
The `process::http` using declaration is used for much more, e.g. `Response`, `Request`, etc. It's only added where required to disambiguate from functions with the same name in another namespace. I believe that's fairly standard practice?
I can remove it if you want, but then I'd probably prefer to remove the `using namespace process` as well, to be consistent.
> On May 25, 2018, 3:37 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/examples/example.cpp
> > Lines 128-129 (original), 120-121 (patched)
> > <https://reviews.apache.org/r/67270/diff/4/?file=2028088#file2028088line135>
> >
> > Without this `main` does nothing useful anymore, let's leave this in for now.
On the contrary, it runs a working HTTP server. If it's not commented out, `main` immediately commits suicide, which imho hardly qualifies as "doing something useful".
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/#review203886
-----------------------------------------------------------
On May 24, 2018, 1:33 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67270/
> -----------------------------------------------------------
>
> (Updated May 24, 2018, 1:33 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> * Added the mandatory help string argument to calls
> to 'route()', failing compilation.
>
> * The response returned from the '/vars' endpoint had
> its 'type' field set to 'NONE', causing indefinite
> hanging when trying to access the endpoint. Switched
> to a constructor for OK that implicitly sets that field.
>
> * Removed a stray pid variable in main.
>
> * Added http:: namespace to disambiguate calls to 'post()'.
>
> * Commented out example code that commits instant
> self-termination by default.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/examples/example.cpp 8c507aefa050543dfa6184626c494918c96d35e7
>
>
> Diff: https://reviews.apache.org/r/67270/diff/4/
>
>
> Testing
> -------
>
> Compiled the `example.cpp` file.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67270: Fixed compilation issues in libprocess
example.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On May 25, 2018, 5:37 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/examples/example.cpp
> > Lines 128-129 (original), 120-121 (patched)
> > <https://reviews.apache.org/r/67270/diff/4/?file=2028088#file2028088line135>
> >
> > Without this `main` does nothing useful anymore, let's leave this in for now.
>
> Benno Evers wrote:
> On the contrary, it runs a working HTTP server. If it's not commented out, `main` immediately commits suicide, which imho hardly qualifies as "doing something useful".
Makes sense.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/#review203886
-----------------------------------------------------------
On May 24, 2018, 3:33 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67270/
> -----------------------------------------------------------
>
> (Updated May 24, 2018, 3:33 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> * Added the mandatory help string argument to calls
> to 'route()', failing compilation.
>
> * The response returned from the '/vars' endpoint had
> its 'type' field set to 'NONE', causing indefinite
> hanging when trying to access the endpoint. Switched
> to a constructor for OK that implicitly sets that field.
>
> * Removed a stray pid variable in main.
>
> * Added http:: namespace to disambiguate calls to 'post()'.
>
> * Commented out example code that commits instant
> self-termination by default.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/examples/example.cpp 8c507aefa050543dfa6184626c494918c96d35e7
>
>
> Diff: https://reviews.apache.org/r/67270/diff/4/
>
>
> Testing
> -------
>
> Compiled the `example.cpp` file.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67270: Fixed compilation issues in libprocess
example.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/#review203886
-----------------------------------------------------------
3rdparty/libprocess/examples/example.cpp
Line 106 (original), 98 (patched)
<https://reviews.apache.org/r/67270/#comment286242>
If you add this and the one below you should remove the `using` decl for `process::http` on top.
Or just leave this as it was for now.
3rdparty/libprocess/examples/example.cpp
Lines 128-129 (original), 120-121 (patched)
<https://reviews.apache.org/r/67270/#comment286241>
Without this `main` does nothing useful anymore, let's leave this in for now.
- Benjamin Bannier
On May 24, 2018, 3:33 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67270/
> -----------------------------------------------------------
>
> (Updated May 24, 2018, 3:33 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> * Added the mandatory help string argument to calls
> to 'route()', failing compilation.
>
> * The response returned from the '/vars' endpoint had
> its 'type' field set to 'NONE', causing indefinite
> hanging when trying to access the endpoint. Switched
> to a constructor for OK that implicitly sets that field.
>
> * Removed a stray pid variable in main.
>
> * Added http:: namespace to disambiguate calls to 'post()'.
>
> * Commented out example code that commits instant
> self-termination by default.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/examples/example.cpp 8c507aefa050543dfa6184626c494918c96d35e7
>
>
> Diff: https://reviews.apache.org/r/67270/diff/4/
>
>
> Testing
> -------
>
> Compiled the `example.cpp` file.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67270: Fixed compilation issues in libprocess
example.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/
-----------------------------------------------------------
(Updated May 24, 2018, 1:33 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Fix uncompilable code in commented-out sections.
Summary (updated)
-----------------
Fixed compilation issues in libprocess example.
Repository: mesos
Description (updated)
-------
* Added the mandatory help string argument to calls
to 'route()', failing compilation.
* The response returned from the '/vars' endpoint had
its 'type' field set to 'NONE', causing indefinite
hanging when trying to access the endpoint. Switched
to a constructor for OK that implicitly sets that field.
* Removed a stray pid variable in main.
* Added http:: namespace to disambiguate calls to 'post()'.
* Commented out example code that commits instant
self-termination by default.
Diffs (updated)
-----
3rdparty/libprocess/examples/example.cpp 8c507aefa050543dfa6184626c494918c96d35e7
Diff: https://reviews.apache.org/r/67270/diff/4/
Changes: https://reviews.apache.org/r/67270/diff/3-4/
Testing
-------
Compiled the `example.cpp` file.
Thanks,
Benno Evers