You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/01/16 02:49:29 UTC
[GitHub] [kafka] tang7526 opened a new pull request #9917: KAFKA-12200 Migrate connect:file module to JUnit 5
tang7526 opened a new pull request #9917:
URL: https://github.com/apache/kafka/pull/9917
https://issues.apache.org/jira/browse/KAFKA-12200
replace junit4 methods with junit5 methods
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #9917: KAFKA-12200 Migrate connect:file module to JUnit 5
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #9917:
URL: https://github.com/apache/kafka/pull/9917
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tang7526 commented on a change in pull request #9917: KAFKA-12200 Migrate connect:file module to JUnit 5
Posted by GitBox <gi...@apache.org>.
tang7526 commented on a change in pull request #9917:
URL: https://github.com/apache/kafka/pull/9917#discussion_r559202712
##########
File path: build.gradle
##########
@@ -2075,8 +2075,7 @@ project(':connect:file') {
compile libs.slf4jApi
testCompile libs.easymock
- testCompile libs.junitJupiterApi
- testCompile libs.junitVintageEngine
+ testCompile libs.junitJupiter
testCompile libs.powermockJunit4
Review comment:
Done. They are already removed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #9917: KAFKA-12200 Migrate connect:file module to JUnit 5
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9917:
URL: https://github.com/apache/kafka/pull/9917#issuecomment-761744136
For some reason, the Jenkins job didn't trigger. Can you please merge trunk to this branch to see if that fixes it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #9917: KAFKA-12200 Migrate connect:file module to JUnit 5
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #9917:
URL: https://github.com/apache/kafka/pull/9917#discussion_r558986411
##########
File path: build.gradle
##########
@@ -242,7 +242,7 @@ subprojects {
}
// Remove the relevant project name once it's converted to JUnit 5
- def shouldUseJUnit5 = !(["api", "connect", "core", "file", "generator", "runtime", "examples",
+ def shouldUseJUnit5 = !(["api", "connect", "core", "generator", "runtime", "examples",
Review comment:
You also have to update the JUnit dependency in the build, check one of the recent related commits for an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9917: KAFKA-12200 Migrate connect:file module to JUnit 5
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9917:
URL: https://github.com/apache/kafka/pull/9917#discussion_r559187734
##########
File path: build.gradle
##########
@@ -2075,8 +2075,7 @@ project(':connect:file') {
compile libs.slf4jApi
testCompile libs.easymock
- testCompile libs.junitJupiterApi
- testCompile libs.junitVintageEngine
+ testCompile libs.junitJupiter
testCompile libs.powermockJunit4
Review comment:
It seems power mock is not used by this module anymore. Could we remove them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #9917: KAFKA-12200 Migrate connect:file module to JUnit 5
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9917:
URL: https://github.com/apache/kafka/pull/9917#issuecomment-761578098
Thanks for the PR. You also need to remove the project name from the `build.gradle` filter:
https://github.com/apache/kafka/blob/trunk/build.gradle#L245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org