You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "romainmoreau (via GitHub)" <gi...@apache.org> on 2024/06/14 14:18:15 UTC
[PR] [FIX] race condition avoided [james-project]
romainmoreau opened a new pull request, #2304:
URL: https://github.com/apache/james-project/pull/2304
With PLAIN auth, flushing before popping `ImapLineHandler` in `AuthenticateProcessor` will result sometimes in this `ImapLineHandler` to also consume the next IMAP command.
It can be reproduced with this simple demo:
```java
for (var i = 0; i < 10_000; i++) {
Session.getInstance(getProperties()).getStore().connect("user", "password");
}
```
Without this patch, the problem occurs on average every 500 authentications in my environment.
With the patch, the demo loop completes every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [FIX] race condition avoided [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa merged PR #2304:
URL: https://github.com/apache/james-project/pull/2304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [FIX] race condition avoided [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #2304:
URL: https://github.com/apache/james-project/pull/2304#issuecomment-2168257569
We can do a @RepeatedTest(50)
One run would not be enough to catch the issue but over several builds we would catch regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [FIX] race condition avoided [james-project]
Posted by "romainmoreau (via GitHub)" <gi...@apache.org>.
romainmoreau commented on PR #2304:
URL: https://github.com/apache/james-project/pull/2304#issuecomment-2174472837
#2307 was opened for the unit test (I finally did like `shouldSupportManyConcurrentSSLConnections` because it was more effective to reproduce the issue).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [FIX] race condition avoided [james-project]
Posted by "romainmoreau (via GitHub)" <gi...@apache.org>.
romainmoreau commented on PR #2304:
URL: https://github.com/apache/james-project/pull/2304#issuecomment-2168845817
Yes I noticed your previous PR #1432 and I tested my change with Evolution, I didn't see any error when logging in with login/password or listing; also no unit test seems to fail, so I was hoping you'd remember why it was added.
Thanks for the pointers for making the unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org