Re: [PR] HBASE-29272 When Spark reads an HBase snapshot, it always read empty … [hbase]

["terrytlu (via GitHub)" <gi...@apache.org>]

terrytlu commented on PR #6947:
URL: https://github.com/apache/hbase/pull/6947#issuecomment-5059041438

   @Apache9 @guluo2016  Thanks for the review, , and sorry for the late response...
   
   I have updated the PRs according to the review comments:
   
   For branch-2.5 (#8492), branch-2.6 (#8493) and branch-3.0 (#8494): since TableSnapshotInputFormat.TableSnapshotRegionSplit is an @InterfaceAudience.Public class, the old 5-arg constructor is kept but marked as @Deprecated (since 2.5.16 / 2.6.7 / 3.0.0, to be removed in 4.0.0), and a new 6-arg constructor with the length parameter is added.
   For master (#6947): the constructor is changed directly to the 6-arg version, and the deprecated 5-arg one is removed since master targets 4.0.0.
   
   The commits are squashed into a single one for a cleaner history, with @guluo2016 listed as co-author, as much of the improvement came from his review and changes.
   
   Please take another look and let me know if anything else needs to be changed. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org