[GitHub] [ozone] devmadhuu commented on a diff in pull request #3766: HDDS-7232. Introduce container-level lock while handling container report events by SCM and Recon

[GitBox <gi...@apache.org>]

devmadhuu commented on code in PR #3766:
URL: https://github.com/apache/ozone/pull/3766#discussion_r976813521


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerStateManagerImpl.java:
##########
@@ -438,14 +450,14 @@ public ContainerInfo getMatchingContainer(final long size, String owner,
     final ContainerID lastID =
         lastUsedMap.getOrDefault(key, containerIDs.first());
 
+    lockManager.readLock(lastID);

Review Comment:
   Yes , makes sense. I will take care for taking lock at container level for each container inside findContainerWithSpace.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org