[GitHub] eirikbakke commented on a change in pull request #507: [NETBEANS-403] Avoid scrolling to end of file if End is pressed while popup is open.

[GitBox <gi...@apache.org>]

eirikbakke commented on a change in pull request #507: [NETBEANS-403] Avoid scrolling to end of file if End is pressed while popup is open.
URL: https://github.com/apache/incubator-netbeans/pull/507#discussion_r187394365
 
 

 ##########
 File path: editor.lib/src/org/netbeans/editor/PopupManager.java
 ##########
 @@ -478,8 +478,10 @@ private static Placement determinePlacement(Placement placement, Dimension prefS
                 KeyStroke ks = KeyStroke.getKeyStrokeForEvent(e);
                 Object obj = im.get(ks);
                 LOG.log(Level.FINE, "Keystroke for event {0}: {1}; action-map-key={2}", new Object [] { e, ks, obj }); //NOI18N
-                if (obj != null && !obj.equals("tooltip-no-action") //NOI18N ignore ToolTipSupport installed actions
-                ) {
+                /* NETBEANS-403: Avoid forwarding actions into simple text popups, such as those
+                created by ToolTipSupport.setToolTipText. The actions will still work if the
+                popup receives explicit focus. */
+                if (obj != null && !(popup instanceof JTextComponent)) {
 
 Review comment:
   Just let me know your preferred course of action, and I can make a new patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists