You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2023/01/17 02:01:43 UTC

[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module

ashulin commented on code in PR #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071674542


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/OptionRule.java:
##########
@@ -195,8 +195,9 @@ public <T> Builder conditional(@NonNull Option<T> conditionalOption, @NonNull Li
 
         public <T> Builder conditional(@NonNull Option<T> conditionalOption, @NonNull T expectValue, @NonNull Option<?>... requiredOptions) {
             for (Option<?> o : requiredOptions) {
-                verifyDuplicate(o, "ConditionalOption");

Review Comment:
   IMO, submit a new PR to deal with this issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org