[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6507: Externalizes logrotate service frequency timer in VR

[GitBox <gi...@apache.org>]

sureshanaparti commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r908022029


##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,6 +2126,11 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile profile
             }
         }
 
+        String routerLogrotateFrequency = RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+        s_logger.debug(String.format("The global setting [%s], with value [%s], will be used to configure the logrotate service frequency on the virtual router.",

Review Comment:
   It's not from the global setting always, so better to log zone id as well.
   
   ```suggestion
           s_logger.debug(String.format("The setting [%s] with value [%s] for the zone [%s], will be used to configure the logrotate service frequency on the virtual router.",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org