You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/10/23 00:06:55 UTC

[GitHub] [druid] sthetland opened a new pull request #10528: cleaning up and fixing links

sthetland opened a new pull request #10528:
URL: https://github.com/apache/druid/pull/10528


   This PR makes the format of the links consistent to the prevailing style in the docs and fixes a few broken external links. 
   
   Using .md in link text rather than .html causes Docusarus to convert the links into absolute links rather than using relative links, making the docs easier to port to other contexts. 
   
   Also updating a few broken external links. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] suneet-s commented on pull request #10528: cleaning up and fixing links

Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #10528:
URL: https://github.com/apache/druid/pull/10528#issuecomment-747717336


   Thanks for the contribution @sthetland !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] suneet-s merged pull request #10528: cleaning up and fixing links

Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #10528:
URL: https://github.com/apache/druid/pull/10528


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] sthetland commented on pull request #10528: cleaning up and fixing links

Posted by GitBox <gi...@apache.org>.
sthetland commented on pull request #10528:
URL: https://github.com/apache/druid/pull/10528#issuecomment-747716479


   Thanks @suneet-s.  I didn't use a script, no. I found these by search & replace, since each one required manual confirmation. I think it may be possible to automate, if we could come up with a clever enough regex, but I didn't get there while making these changes. Maybe be worth looking into.   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10528: cleaning up and fixing links

Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on a change in pull request #10528:
URL: https://github.com/apache/druid/pull/10528#discussion_r585456441



##########
File path: docs/querying/caching.md
##########
@@ -82,17 +82,3 @@ Note that the task executor processes only support caches that keep their data l
 This restriction exists because the cache stores results at the level of intermediate partial segments generated by the
 ingestion tasks. These intermediate partial segments will not necessarily be identical across task replicas, so
 remote cache types such as `memcached` will be ignored by task executor processes.
-
-## Unsupported queries

Review comment:
       Hi @sthetland  what was the reason for removing this para in this PR? was it accidental? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org