You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/05/03 16:57:55 UTC

Review Request 46937: GEODE-17 - use null instead of "NULL" for regionName

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46937/
-----------------------------------------------------------

Review request for geode, Jens Deppe and Kirk Lund.


Repository: geode


Description
-------

* use null instead of "NULL" for regionName
* create an example JSONAuthorization that initialize with a default security.json file.


Diffs
-----

  geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java 7f6f72e7aebe2f4ef80cdcf57bdc12680cfdecac 
  geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ExampleJSONAuthorization.java PRE-CREATION 
  geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java 7f1d2bfd100385f03534ec30c39c9f4cf793719a 
  geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContextJUnitTest.java 318d3272419cc03be1f00b2bcd2d80a41a07baf6 

Diff: https://reviews.apache.org/r/46937/diff/


Testing
-------

precheckin


Thanks,

Jinmei Liao


Re: Review Request 46937: GEODE-17 - use null instead of "NULL" for regionName

Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46937/#review133153
-----------------------------------------------------------


Ship it!




Ship It!

- Kirk Lund


On May 3, 2016, 2:57 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46937/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 2:57 p.m.)
> 
> 
> Review request for geode, Jens Deppe and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> * use null instead of "NULL" for regionName
> * create an example JSONAuthorization that initialize with a default security.json file.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java 7f6f72e7aebe2f4ef80cdcf57bdc12680cfdecac 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ExampleJSONAuthorization.java PRE-CREATION 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java 7f1d2bfd100385f03534ec30c39c9f4cf793719a 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContextJUnitTest.java 318d3272419cc03be1f00b2bcd2d80a41a07baf6 
> 
> Diff: https://reviews.apache.org/r/46937/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>


Re: Review Request 46937: GEODE-17 - use null instead of "NULL" for regionName

Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46937/#review131511
-----------------------------------------------------------


Ship it!




Ship It!

- Jens Deppe


On May 3, 2016, 2:57 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46937/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 2:57 p.m.)
> 
> 
> Review request for geode, Jens Deppe and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> * use null instead of "NULL" for regionName
> * create an example JSONAuthorization that initialize with a default security.json file.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java 7f6f72e7aebe2f4ef80cdcf57bdc12680cfdecac 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ExampleJSONAuthorization.java PRE-CREATION 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java 7f1d2bfd100385f03534ec30c39c9f4cf793719a 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContextJUnitTest.java 318d3272419cc03be1f00b2bcd2d80a41a07baf6 
> 
> Diff: https://reviews.apache.org/r/46937/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>