You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/02/21 12:49:01 UTC
Review Request 56883: Log Search: only update schema file for Solr if
it has any new fields in the local file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56883/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-20096
https://issues.apache.org/jira/browse/AMBARI-20096
Repository: ambari
Description
-------
Currently we upload the managed-schema file (for collections: history, service logs, audit logs) to zookeeper in case of the local file content differs from the zookeeper one. Because Solr itself can edit the file, that is a wrong solution. Instead of the we will check is there any new nodes in the local xml file. (if there is any, we will upload that to zookeeper)
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java 23defea
Diff: https://reviews.apache.org/r/56883/diff/
Testing
-------
done.
Thanks,
Oliver Szabo
Re: Review Request 56883: Log Search: only update schema file for
Solr if it has any new fields in the local file
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56883/#review166162
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java (line 110)
<https://reviews.apache.org/r/56883/#comment238047>
The name isLocalSchemaFileHasMoreFields is a bit weird, it should be either localSchemaFileHasMoreFields, or areMoreFieldsInLocalSchemaFile
- Miklos Gergely
On Feb. 21, 2017, 12:49 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56883/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 12:49 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-20096
> https://issues.apache.org/jira/browse/AMBARI-20096
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently we upload the managed-schema file (for collections: history, service logs, audit logs) to zookeeper in case of the local file content differs from the zookeeper one. Because Solr itself can edit the file, that is a wrong solution. Instead of the we will check is there any new nodes in the local xml file. (if there is any, we will upload that to zookeeper)
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java 23defea
>
> Diff: https://reviews.apache.org/r/56883/diff/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 56883: Log Search: only update schema file for
Solr if it has any new fields in the local file
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56883/#review166175
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Feb. 21, 2017, 1:23 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56883/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 1:23 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-20096
> https://issues.apache.org/jira/browse/AMBARI-20096
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently we upload the managed-schema file (for collections: history, service logs, audit logs) to zookeeper in case of the local file content differs from the zookeeper one. Because Solr itself can edit the file, that is a wrong solution. Instead of the we will check is there any new nodes in the local xml file. (if there is any, we will upload that to zookeeper)
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java 23defea
>
> Diff: https://reviews.apache.org/r/56883/diff/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 56883: Log Search: only update schema file for
Solr if it has any new fields in the local file
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56883/
-----------------------------------------------------------
(Updated Feb. 21, 2017, 1:23 p.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Changes
-------
rename method
Bugs: AMBARI-20096
https://issues.apache.org/jira/browse/AMBARI-20096
Repository: ambari
Description
-------
Currently we upload the managed-schema file (for collections: history, service logs, audit logs) to zookeeper in case of the local file content differs from the zookeeper one. Because Solr itself can edit the file, that is a wrong solution. Instead of the we will check is there any new nodes in the local xml file. (if there is any, we will upload that to zookeeper)
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java 23defea
Diff: https://reviews.apache.org/r/56883/diff/
Testing
-------
done.
Thanks,
Oliver Szabo