You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2014/11/05 05:49:21 UTC
[jira] [Commented] (THRIFT-2745) C++ - Unit-test compilation on
Windows fixes
[ https://issues.apache.org/jira/browse/THRIFT-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197587#comment-14197587 ]
Hudson commented on THRIFT-2745:
--------------------------------
SUCCESS: Integrated in Thrift #1331 (See [https://builds.apache.org/job/Thrift/1331/])
THRIFT-2745: c++ - fixed some unit test compilation on windows (hcorg: rev 293a40e960d87d83ec57f89738c3ec174981335b)
* lib/cpp/test/concurrency/ThreadManagerTests.h
* lib/cpp/test/concurrency/TimerManagerTests.h
* lib/cpp/test/concurrency/ThreadFactoryTests.h
> C++ - Unit-test compilation on Windows fixes
> --------------------------------------------
>
> Key: THRIFT-2745
> URL: https://issues.apache.org/jira/browse/THRIFT-2745
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library, Test Suite
> Affects Versions: 1.0
> Environment: Windows 7 (64bit)
> Microsoft Visual Studio 2012
> Reporter: Sergei Nikulov
> Assignee: Sergei Nikulov
> Priority: Minor
> Fix For: 0.9.2
>
>
> Issue 1:
> thrift\lib\cpp\test\concurrency\ThreadFactoryTests.h uses <unistd.h> for usleep().
> Replaced usleep() with THRIFT_SLEEP_USEC() and removed inclusion of unistd.h
> Issue 2:
> static const double ERROR;
> macro ERROR already defined in wingdi.h
> Replaced with TEST_ERROR, but perhaps it is better to find it more better name.
> PR: https://github.com/apache/thrift/pull/207
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)