[GitHub] [doris] englefly commented on a diff in pull request #20713: [tpcds](nereids)adjust cost model for BroadCastJoin and PartitionJoin

["englefly (via GitHub)" <gi...@apache.org>]

englefly commented on code in PR #20713:
URL: https://github.com/apache/doris/pull/20713#discussion_r1231984958


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##########
@@ -252,10 +271,19 @@ public Cost visitPhysicalHashJoin(
                     leftRowCount + rightRowCount,
                     penalty);
         }
+
+        if (context.isBroadcastJoin()) {
+            double broadcastJoinPenalty = broadCastJoinBalancePenalty(probeStats, buildStats);
+            return CostV1.of(leftRowCount * broadcastJoinPenalty + rightRowCount + outputRowCount,

Review Comment:
   this idea can be implemented in CostModelV2. In V1, we do not have this dimension



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org