You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "honeyhexin (Code Review)" <ge...@cloudera.org> on 2019/08/06 05:34:05 UTC
[kudu-CR] [code style] Keep same code style in test files
honeyhexin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14016
Change subject: [code style] Keep same code style in test files
......................................................................
[code style] Keep same code style in test files
Change all ASSERT_NO_FATAL_FAILURE to NO_FATALS
to keep the same code style in test files.
Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
---
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/client/client-test.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/registration-test.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/master/master-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
M src/kudu/tablet/tablet_random_access-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/trace-test.cc
26 files changed, 227 insertions(+), 227 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/14016/1
--
To view, visit http://gerrit.cloudera.org:8080/14016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
Gerrit-Change-Number: 14016
Gerrit-PatchSet: 1
Gerrit-Owner: honeyhexin <ho...@sohu.com>
[kudu-CR] [code style] Keep same code style in test files
Posted by "honeyhexin (Code Review)" <ge...@cloudera.org>.
honeyhexin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14016 )
Change subject: [code style] Keep same code style in test files
......................................................................
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/client/client-test.cc@a4313
PS2, Line 4313:
:
:
:
> Why remove the comment?
As we have discussed offline, delete these useless comments and out-of-date logic.
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/client/client-test.cc@4304
PS2, Line 4304:
> Reindent.
Done
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/consensus/consensus_queue-test.cc
File src/kudu/consensus/consensus_queue-test.cc:
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/consensus/consensus_queue-test.cc@593
PS2, Line 593: NO_FATALS(UpdatePeerWatermarkToOp(&request,
> Reindent the continuation lines here.
Done
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/consensus/raft_consensus_quorum-test.cc
File src/kudu/consensus/raft_consensus_quorum-test.cc:
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/consensus/raft_consensus_quorum-test.cc@1048
PS2, Line 1048: NO_FATALS(AssertDurableTermAndVote(kPeerIndex, last_op_id.term() + 1,
> Reindent all of the continuation lines affected by your change in this file
Done
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/util/env-test.cc
File src/kudu/util/env-test.cc:
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/util/env-test.cc@216
PS2, Line 216: NO_FATALS(ReadAndVerifyTestData(raf.get(), num_slices * slice_size * i,
> Reindent.
Done
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/util/env-test.cc@229
PS2, Line 229: NO_FATALS(ReadAndVerifyTestData(raf.get(), num_slices * slice_size * i,
> Reindent.
Done
--
To view, visit http://gerrit.cloudera.org:8080/14016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
Gerrit-Change-Number: 14016
Gerrit-PatchSet: 3
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 23:28:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [code style] Keep same code style in test files
Posted by "honeyhexin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14016
to look at the new patch set (#2).
Change subject: [code style] Keep same code style in test files
......................................................................
[code style] Keep same code style in test files
Change all ASSERT_NO_FATAL_FAILURE to NO_FATALS
to keep the same code style in test files.
Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
---
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/client/client-test.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/registration-test.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/master/master-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
M src/kudu/tablet/tablet_random_access-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/trace-test.cc
26 files changed, 228 insertions(+), 235 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/14016/2
--
To view, visit http://gerrit.cloudera.org:8080/14016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
Gerrit-Change-Number: 14016
Gerrit-PatchSet: 2
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [code style] Keep same code style in test files
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14016 )
Change subject: [code style] Keep same code style in test files
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
Gerrit-Change-Number: 14016
Gerrit-PatchSet: 4
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 00:08:18 +0000
Gerrit-HasComments: No
[kudu-CR] [code style] Keep same code style in test files
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14016 )
Change subject: [code style] Keep same code style in test files
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
Gerrit-Change-Number: 14016
Gerrit-PatchSet: 3
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 23:46:45 +0000
Gerrit-HasComments: No
[kudu-CR] [code style] Keep same code style in test files
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14016 )
Change subject: [code style] Keep same code style in test files
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/client/client-test.cc@a4313
PS2, Line 4313:
:
:
:
Why remove the comment?
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/client/client-test.cc@4304
PS2, Line 4304: NO_FATALS(InsertTestRows(client_.get(),
Reindent.
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/consensus/consensus_queue-test.cc
File src/kudu/consensus/consensus_queue-test.cc:
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/consensus/consensus_queue-test.cc@593
PS2, Line 593: NO_FATALS(UpdatePeerWatermarkToOp(&request,
Reindent the continuation lines here.
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/consensus/raft_consensus_quorum-test.cc
File src/kudu/consensus/raft_consensus_quorum-test.cc:
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/consensus/raft_consensus_quorum-test.cc@1048
PS2, Line 1048: NO_FATALS(AssertDurableTermAndVote(kPeerIndex, last_op_id.term() + 1,
Reindent all of the continuation lines affected by your change in this file.
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/util/env-test.cc
File src/kudu/util/env-test.cc:
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/util/env-test.cc@216
PS2, Line 216: NO_FATALS(ReadAndVerifyTestData(raf.get(), num_slices * slice_size * i,
Reindent.
http://gerrit.cloudera.org:8080/#/c/14016/2/src/kudu/util/env-test.cc@229
PS2, Line 229: NO_FATALS(ReadAndVerifyTestData(raf.get(), num_slices * slice_size * i,
Reindent.
--
To view, visit http://gerrit.cloudera.org:8080/14016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
Gerrit-Change-Number: 14016
Gerrit-PatchSet: 2
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 06 Aug 2019 17:31:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] [code style] Keep same code style in test files
Posted by "honeyhexin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14016
to look at the new patch set (#3).
Change subject: [code style] Keep same code style in test files
......................................................................
[code style] Keep same code style in test files
Change all ASSERT_NO_FATAL_FAILURE to NO_FATALS
to keep the same code style in test files. In addition,
delete out-of-date logic in client-test.
Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
---
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/client/client-test.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/registration-test.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/master/master-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
M src/kudu/tablet/tablet_random_access-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/trace-test.cc
26 files changed, 242 insertions(+), 255 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/14016/3
--
To view, visit http://gerrit.cloudera.org:8080/14016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
Gerrit-Change-Number: 14016
Gerrit-PatchSet: 3
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [code style] Keep same code style in test files
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14016 )
Change subject: [code style] Keep same code style in test files
......................................................................
[code style] Keep same code style in test files
Change all ASSERT_NO_FATAL_FAILURE to NO_FATALS
to keep the same code style in test files. In addition,
delete out-of-date logic in client-test.
Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
Reviewed-on: http://gerrit.cloudera.org:8080/14016
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/client/client-test.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/registration-test.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/master/master-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
M src/kudu/tablet/tablet_random_access-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/trace-test.cc
26 files changed, 261 insertions(+), 287 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
Gerrit-Change-Number: 14016
Gerrit-PatchSet: 5
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>
[kudu-CR] [code style] Keep same code style in test files
Posted by "honeyhexin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14016
to look at the new patch set (#4).
Change subject: [code style] Keep same code style in test files
......................................................................
[code style] Keep same code style in test files
Change all ASSERT_NO_FATAL_FAILURE to NO_FATALS
to keep the same code style in test files. In addition,
delete out-of-date logic in client-test.
Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
---
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/client/client-test.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/registration-test.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/master/master-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
M src/kudu/tablet/tablet_random_access-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/trace-test.cc
26 files changed, 261 insertions(+), 287 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/14016/4
--
To view, visit http://gerrit.cloudera.org:8080/14016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67689fe8113d88f60ac33fa38504813128209da3
Gerrit-Change-Number: 14016
Gerrit-PatchSet: 4
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>