[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1172: Append shell stdout to persistent log

[GitBox <gi...@apache.org>]

peacewong commented on a change in pull request #1172:
URL: https://github.com/apache/incubator-linkis/pull/1172#discussion_r764815625



##########
File path: linkis-engineconn-plugins/engineconn-plugins/shell/src/main/scala/org/apache/linkis/manager/engineplugin/shell/executor/ShellEngineConnExecutor.scala
##########
@@ -77,6 +77,7 @@ class ShellEngineConnExecutor(id: Int) extends ComputationExecutor with Logging
       }) {
         info(line)
         engineExecutionContext.appendTextResultSet(line)
+        engineExecutionContext.appendStdout(line)

Review comment:
       In order to reduce the number of messages, it is recommended to modify it to push by log.`LogHelper.logCache.cacheLog(line)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org