You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/09/25 01:16:17 UTC
[GitHub] [zookeeper] xiaotian-qi opened a new pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
xiaotian-qi opened a new pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466
Within ```zoo_sasl_client_destroy```, it carefully free all members of the sasl client, while here it doesn't free the struct itself before set it to NULL. This error is detected by leak sanitizer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466#issuecomment-698718558
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466#issuecomment-698755064
CI failed
I have restarted the validation
https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-precommit-github-pr/detail/PR-1466/2/pipeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466#issuecomment-698823263
@eolivelli, @anmolnar @symat:
> we should cherry-pick this fix to at least branch-3.6, probably also onto branch-3.5 is better
No need to; the C client only has SASL support in 3.7.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg edited a comment on pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
Posted by GitBox <gi...@apache.org>.
ztzg edited a comment on pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466#issuecomment-698718483
@eolivelli, @symat: This is independent from my https://github.com/apache/zookeeper/pull/1457; they can be applied in any order.
Also: I believe the test failure is spurious. Do we have a new "retest" magic phrase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466#issuecomment-699831711
the patch is merged to the master branch, thanks @xiaotian-qi for the fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg removed a comment on pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
Posted by GitBox <gi...@apache.org>.
ztzg removed a comment on pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466#issuecomment-698718558
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466#issuecomment-698718483
@eolivelli, @symat: This is independent from my https://github.com/apache/zookeeper/pull/1457; they can be applied in any order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg edited a comment on pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
Posted by GitBox <gi...@apache.org>.
ztzg edited a comment on pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466#issuecomment-698718483
@eolivelli, @symat: This is independent from my https://github.com/apache/zookeeper/pull/1457; they can be applied in any order.
Also: I believe the test failure is spurious. Do we have a new "retest" magic phrase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg removed a comment on pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
Posted by GitBox <gi...@apache.org>.
ztzg removed a comment on pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466#issuecomment-698718558
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466#issuecomment-698755064
CI failed
I have restarted the validation
https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-precommit-github-pr/detail/PR-1466/2/pipeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1466: ZOOKEEPER-3944 Fix sasl memory leak
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1466:
URL: https://github.com/apache/zookeeper/pull/1466#issuecomment-698718483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org