You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by mi...@apache.org on 2010/11/30 00:14:46 UTC

svn commit: r1040337 - in /jakarta/jmeter/trunk: src/components/org/apache/jmeter/visualizers/RenderAsXML.java src/components/org/apache/jmeter/visualizers/SamplerResultTab.java xdocs/changes.xml

Author: milamber
Date: Mon Nov 29 23:14:46 2010
New Revision: 1040337

URL: http://svn.apache.org/viewvc?rev=1040337&view=rev
Log:
Bug 50367 - Clear / Clear all in View results tree does not clear selected element

Modified:
    jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java
    jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java
    jakarta/jmeter/trunk/xdocs/changes.xml

Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java?rev=1040337&r1=1040336&r2=1040337&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java (original)
+++ jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java Mon Nov 29 23:14:46 2010
@@ -89,6 +89,15 @@ public class RenderAsXML extends Sampler
         resultsScrollPane.setViewportView(domTreePanel);
     }
 
+    /* (non-Javadoc)
+     * @see org.apache.jmeter.visualizers.SamplerResultTab#clearData()
+     */
+    @Override
+    public void clearData() {
+        super.clearData();
+        resultsScrollPane.setViewportView(null); // clear result tab on Ctrl-E
+    }
+
     /*
      *
      * A Dom tree panel for to display response as tree view author <a

Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java?rev=1040337&r1=1040336&r2=1040337&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java (original)
+++ jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java Mon Nov 29 23:14:46 2010
@@ -191,6 +191,10 @@ public abstract class SamplerResultTab i
     public void clearData() {
         results.setText("");// Response Data // $NON-NLS-1$
         requestPanel.clearData();// Request Data // $NON-NLS-1$
+        stats.setText(""); // Sampler result // $NON-NLS-1$
+        resultModel.clearData();
+        resHeadersModel.clearData();
+        resFieldsModel.clearData();
     }
 
     public void init() {
@@ -202,12 +206,10 @@ public abstract class SamplerResultTab i
 
     @SuppressWarnings("boxing")
     public void setupTabPane() {
+        // Clear all data before display a new
+        this.clearData();
         StyledDocument statsDoc = stats.getStyledDocument();
         try {
-            // Clear data before display a new
-            statsDoc.remove(0, statsDoc.getLength());
-            requestPanel.clearData();
-            results.setText(""); // $NON-NLS-1$
             if (userObject instanceof SampleResult) {
                 sampleResult = (SampleResult) userObject;
                 // We are displaying a SampleResult
@@ -271,9 +273,7 @@ public abstract class SamplerResultTab i
                 statsDoc.insertString(statsDoc.getLength(), statsBuff.toString(), null);
                 statsBuff = null; // Done
                 
-                // Tabbed results      
-                resultModel.clearData(); // clear results table before filling
-                // fill table
+                // Tabbed results: fill table
                 resultModel.addRow(new RowResult(JMeterUtils.getParsedLabel("view_results_thread_name"), sampleResult.getThreadName())); //$NON-NLS-1$
                 resultModel.addRow(new RowResult(JMeterUtils.getParsedLabel("view_results_sample_start"), startTime)); //$NON-NLS-1$
                 resultModel.addRow(new RowResult(JMeterUtils.getParsedLabel("view_results_load_time"), sampleResult.getTime())); //$NON-NLS-1$
@@ -284,7 +284,6 @@ public abstract class SamplerResultTab i
                 resultModel.addRow(new RowResult(JMeterUtils.getParsedLabel("view_results_response_code"), responseCode)); //$NON-NLS-1$
                 resultModel.addRow(new RowResult(JMeterUtils.getParsedLabel("view_results_response_message"), responseMsgStr)); //$NON-NLS-1$
                 
-                resHeadersModel.clearData(); // clear response table before filling
                 // Parsed response headers
                 LinkedHashMap<String, String> lhm = JMeterUtils.parseHeaders(sampleResult.getResponseHeaders());
                 Set<String> keySet = lhm.keySet();
@@ -292,7 +291,7 @@ public abstract class SamplerResultTab i
                     resHeadersModel.addRow(new RowResult(key, lhm.get(key)));
                 }
                 
-                resFieldsModel.clearData(); // clear fields table before filling
+                // Fields table
                 resFieldsModel.addRow(new RowResult("Type Result ", typeResult)); //$NON-NLS-1$
                 //not sure needs I18N?
                 resFieldsModel.addRow(new RowResult("ContentType", sampleResult.getContentType())); //$NON-NLS-1$

Modified: jakarta/jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/changes.xml?rev=1040337&r1=1040336&r2=1040337&view=diff
==============================================================================
--- jakarta/jmeter/trunk/xdocs/changes.xml (original)
+++ jakarta/jmeter/trunk/xdocs/changes.xml Mon Nov 29 23:14:46 2010
@@ -87,6 +87,7 @@ This has been replaced by the instance m
 
 <h3>Listeners</h3>
 <ul>
+<li>Bug 50367 - Clear / Clear all in View results tree does not clear selected element</li>
 </ul>
 
 <h3>Assertions</h3>



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org