You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "mark4z (via GitHub)" <gi...@apache.org> on 2023/02/23 09:27:54 UTC
[GitHub] [dubbo] mark4z opened a new issue, #11639: [BUG]Service Name Mapping
mark4z opened a new issue, #11639:
URL: https://github.com/apache/dubbo/issues/11639
<!-- If you need to report a security issue please visit https://github.com/apache/dubbo/security/policy -->
- [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.2
* Operating System version: xxx
* Java version: xxx
### Steps to reproduce this issue
boolean contains = StringUtils.isContains(oldConfigContent, appName) has problem.
oldConfigContentis a list of service names. If strings.Contains(oldVal, appName), then the SNP registration will be skipped, e.g. if oldConfigContentis = dubbo.io-2 and appName= dubbo.io, then newServiceName will be skipped.
Pls. provide [GitHub address] to reproduce this issue.
### Expected Behavior
<!-- What do you expect from the above steps？-->
### Actual Behavior
<!-- What actually happens? -->
```java
MetadataServiceNameMapping.java
public boolean map(URL url) {
boolean result = true;
for (Map.Entry<String, MetadataReport> entry : metadataReportInstance.getMetadataReports(true).entrySet()) {
do {
ConfigItem configItem = metadataReport.getConfigItem(serviceInterface, DEFAULT_MAPPING_GROUP);
String oldConfigContent = configItem.getContent();
if (StringUtils.isNotEmpty(oldConfigContent)) {
boolean contains = StringUtils.isContains(oldConfigContent, appName);
if (contains) {
// From the user's perspective, it means successful when the oldConfigContent has contained the current appName. So we should not throw an Exception to user, it will confuse the user.
succeeded = true;
break;
}
}
```
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] mark4z commented on issue #11639: [BUG]Service Name Mapping
Posted by "mark4z (via GitHub)" <gi...@apache.org>.
mark4z commented on issue #11639:
URL: https://github.com/apache/dubbo/issues/11639#issuecomment-1441438015
@AlbumenJ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ closed issue #11639: [BUG]Service Name Mapping
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ closed issue #11639: [BUG]Service Name Mapping
URL: https://github.com/apache/dubbo/issues/11639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] aamingaa commented on issue #11639: [BUG]Service Name Mapping
Posted by "aamingaa (via GitHub)" <gi...@apache.org>.
aamingaa commented on issue #11639:
URL: https://github.com/apache/dubbo/issues/11639#issuecomment-1442724826
https://github.com/apache/dubbo/pull/11643/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org