You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Anita Anandan (JIRA)" <de...@myfaces.apache.org> on 2008/08/29 23:55:44 UTC

[jira] Created: (TRINIDAD-1210) org.apache.myfaces.trinidad.convert.DateTimeConverter uses a Set which may imply that the locale pattern is not the 1st to be used

org.apache.myfaces.trinidad.convert.DateTimeConverter uses a Set which may imply that the locale pattern is not the 1st to be used
----------------------------------------------------------------------------------------------------------------------------------

                 Key: TRINIDAD-1210
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1210
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Components
            Reporter: Anita Anandan
            Priority: Minor


org.apache.myfaces.trinidad.convert.DateTimeConverter._doLenientParse() uses a Set (HashSet). Since Set (and HashSet) do not make any guarantee about the order of the elements, it is possible that the locale specified pattern (variable pattern) is not the first to be tried. 

It might also be useful to have an order among the other patterns that make up the Sets "patterns" and "lenientPatterns". 

In order to do so I suggest we make all the above Lists.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-1210) org.apache.myfaces.trinidad.convert.DateTimeConverter uses a Set which may imply that the locale pattern is not the 1st to be used

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627192#action_12627192 ] 

Matthias Weßendorf commented on TRINIDAD-1210:
----------------------------------------------

sounds good to me, thanks for catching it

> org.apache.myfaces.trinidad.convert.DateTimeConverter uses a Set which may imply that the locale pattern is not the 1st to be used
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-1210
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1210
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>            Reporter: Anita Anandan
>            Priority: Minor
>
> org.apache.myfaces.trinidad.convert.DateTimeConverter._doLenientParse() uses a Set (HashSet). Since Set (and HashSet) do not make any guarantee about the order of the elements, it is possible that the locale specified pattern (variable pattern) is not the first to be tried. 
> It might also be useful to have an order among the other patterns that make up the Sets "patterns" and "lenientPatterns". 
> In order to do so I suggest we make all the above Lists.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TRINIDAD-1210) org.apache.myfaces.trinidad.convert.DateTimeConverter uses a Set which may imply that the locale pattern is not the 1st to be used

Posted by "Anita Anandan (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anita Anandan updated TRINIDAD-1210:
------------------------------------

    Status: Patch Available  (was: Open)

> org.apache.myfaces.trinidad.convert.DateTimeConverter uses a Set which may imply that the locale pattern is not the 1st to be used
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-1210
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1210
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>            Reporter: Anita Anandan
>            Priority: Minor
>         Attachments: trunk.patch, trunk12.patch
>
>
> org.apache.myfaces.trinidad.convert.DateTimeConverter._doLenientParse() uses a Set (HashSet). Since Set (and HashSet) do not make any guarantee about the order of the elements, it is possible that the locale specified pattern (variable pattern) is not the first to be tried. 
> It might also be useful to have an order among the other patterns that make up the Sets "patterns" and "lenientPatterns". 
> In order to do so I suggest we make all the above Lists.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TRINIDAD-1210) org.apache.myfaces.trinidad.convert.DateTimeConverter uses a Set which may imply that the locale pattern is not the 1st to be used

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated TRINIDAD-1210:
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0.10-core
                   1.2.10-core
         Assignee: Matthias Weßendorf
           Status: Resolved  (was: Patch Available)

> org.apache.myfaces.trinidad.convert.DateTimeConverter uses a Set which may imply that the locale pattern is not the 1st to be used
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-1210
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1210
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>            Reporter: Anita Anandan
>            Assignee: Matthias Weßendorf
>            Priority: Minor
>             Fix For: 1.2.10-core, 1.0.10-core
>
>         Attachments: trunk.patch, trunk12.patch
>
>
> org.apache.myfaces.trinidad.convert.DateTimeConverter._doLenientParse() uses a Set (HashSet). Since Set (and HashSet) do not make any guarantee about the order of the elements, it is possible that the locale specified pattern (variable pattern) is not the first to be tried. 
> It might also be useful to have an order among the other patterns that make up the Sets "patterns" and "lenientPatterns". 
> In order to do so I suggest we make all the above Lists.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.