You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by theangrydev <gi...@git.apache.org> on 2017/03/19 20:05:06 UTC
[GitHub] httpclient pull request #67: HTTPCLIENT-1830: await termination of the IdleC...
GitHub user theangrydev opened a pull request:
https://github.com/apache/httpclient/pull/67
HTTPCLIENT-1830: await termination of the IdleConnectionEvictor when it is shut down
See [HTTPCLIENT-1830](https://issues.apache.org/jira/browse/HTTPCLIENT-1830) for more details.
I also noticed something weird with the original implementation of this in [HTTPCLIENT-1583](https://issues.apache.org/jira/browse/HTTPCLIENT-1583) that I think means that `HttpClientBuilder.evictExpiredConnections` is not working as intended, see my comment on that ticket.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/theangrydev/httpclient trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit eb225da72048e5ec5be8849b335f88995317be74
Author: Liam Williams <li...@zoho.com>
Date: 2017-03-19T20:01:35Z
HTTPCLIENT-1830: await termination of the IdleConnectionEvictor when it is shut down
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient pull request #67: HTTPCLIENT-1830: await termination of the IdleC...
Posted by theangrydev <gi...@git.apache.org>.
Github user theangrydev closed the pull request at:
https://github.com/apache/httpclient/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient issue #67: HTTPCLIENT-1830: await termination of the IdleConnecti...
Posted by theangrydev <gi...@git.apache.org>.
Github user theangrydev commented on the issue:
https://github.com/apache/httpclient/pull/67
As discussed in [HTTPCLIENT-1830](https://issues.apache.org/jira/browse/HTTPCLIENT-1830), updated this pull request to keep await termination separate from the shutdown. Keeping the uncaught exception logging in trunk but not in 4.5.x and 4.6.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient issue #67: HTTPCLIENT-1830: await termination of the IdleConnecti...
Posted by theangrydev <gi...@git.apache.org>.
Github user theangrydev commented on the issue:
https://github.com/apache/httpclient/pull/67
This has been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org