[GitHub] [ignite-3] ibessonov commented on a change in pull request #685: IGNITE-16534 Make BplusMetaIo abstract

[GitBox <gi...@apache.org>]

ibessonov commented on a change in pull request #685:
URL: https://github.com/apache/ignite-3/pull/685#discussion_r815659014



##########
File path: modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/tree/BplusTree.java
##########
@@ -893,11 +897,12 @@ protected BplusTree(
             long metaPageId,
             @Nullable ReuseList reuseList,
             IoVersions<? extends BplusInnerIo<L>> innerIos,
-            IoVersions<? extends BplusLeafIo<L>> leafIos
+            IoVersions<? extends BplusLeafIo<L>> leafIos,

Review comment:
       I feel like passing a registry and types should be more convenient, what do you think?
   
   Types can even be retrieved from protected methods to reduce a number of parameters in constructor. But if you think that it's a bad solution, just let me know. Invoking virtual methods in constructors is an anti-pattern, I know it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org