[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

[GitBox <gi...@apache.org>]

carterkozak commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load
URL: https://github.com/apache/logging-log4j2/pull/273#discussion_r286261767
 
 

 ##########
 File path: log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorUtil.java
 ##########
 @@ -46,6 +46,11 @@
     private static final int RINGBUFFER_DEFAULT_SIZE = 256 * 1024;
     private static final int RINGBUFFER_NO_GC_DEFAULT_SIZE = 4 * 1024;
 
+    // LOG4J2-2606: Disruptor spins enqueuing events across multiple threads when the queue is full.
+    // CPU utilization is significantly reduced by restricting access to the enqueue operation.
+    static final boolean SYNCHRONIZE_ENQUEUE_WHEN_QUEUE_IS_FULL = PropertiesUtil.getProperties()
+            .getBooleanProperty("AsyncLogger.SynchronizeEnqueueWhenQueueFull", true);
 
 Review comment:
   TODO: Update documentation with this value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services