[GitHub] [accumulo] ctubbsii commented on a change in pull request #2238: Add compaction coordinator and compactor to cluster start / stop scripts

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2238:
URL: https://github.com/apache/accumulo/pull/2238#discussion_r712682547



##########
File path: server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java
##########
@@ -61,6 +61,10 @@ private static void message(String msg, Opts opts) {
     boolean zapTservers = false;
     @Parameter(names = "-tracers", description = "remove tracer locks")
     boolean zapTracers = false;
+    @Parameter(names = "-coordinators", description = "remove compaction coordinator locks")

Review comment:
       > I'm not sure where the confusion would come to play.
   
   I have a whole set of thoughts on naming that answers why I think it's more confusing, but I can't get it down to a reasonable size for a response here. I can try, if it's important. If it's not important, then maybe I can just discuss offline sometime.
   
   In short, I think `-compaction-coordinators` is better here. Yes, it's long, but it's completely unambiguous, and matches with the name of the `KeywordExecutable` service and `bin/accumulo` argument to launch it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org