You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2023/01/30 07:43:22 UTC

[GitHub] [skywalking-python] kezhenxu94 commented on a diff in pull request #273: Remove configuration debts before we release 1.0.0

kezhenxu94 commented on code in PR #273:
URL: https://github.com/apache/skywalking-python/pull/273#discussion_r1090264445


##########
tests/plugin/docker-compose.base.yml:
##########
@@ -35,10 +35,9 @@ services:
   agent:
     image: apache/skywalking-python-agent:latest-plugin
     environment:
-      SW_AGENT_COLLECTOR_BACKEND_SERVICES: collector:19876

Review Comment:
   Some of the env var names (like this one) were deliberately given that names to keep it consistent with other agent's configuration, although I agree you rename to a better one. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org