You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by MariaBukharina <gi...@git.apache.org> on 2014/11/28 11:58:34 UTC
[GitHub] cordova-plugin-geolocation pull request: CB-8094 Pended autotests ...
GitHub user MariaBukharina opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/33
CB-8094 Pended autotests for Windows Store since they require user interaction
https://issues.apache.org/jira/browse/CB-8094
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-geolocation CB-8094
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-geolocation/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit f241443985681e263e566cf71c71b254a818172a
Author: maria.bukharina <ma...@akvelon.com>
Date: 2014-11-28T10:53:56Z
CB-8094 Pended auto tests for Windows Store since they require user interaction
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-8094 Pended autotests ...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/33#discussion_r21073465
--- Diff: tests/tests.js ---
@@ -27,6 +27,7 @@ exports.defineAutoTests = function () {
expect(true).toBe(true);
done();
};
+ var isWindowsStore = (cordova.platformId == "windows" && navigator.appVersion.indexOf("Windows Phone 8.1;")== -1) || (navigator.appVersion.indexOf("MSAppHost/1.0") !== -1)
--- End diff --
I would recommend to use the following way to detect windows desktop/tablet apps
var isWindowsStore = (cordova.platformId == "windows8") || && (cordova.platformId == "windows" && !WinJS.Utilities.isPhone)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-8094 Pended autotests ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-8094 Pended autotests ...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/33#issuecomment-65028770
Otherwise looks good, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org