You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/09/18 19:34:21 UTC

Review Request 38501: Install of packages for newer HDP version is failing

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38501/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-13150
    https://issues.apache.org/jira/browse/AMBARI-13150


Repository: ambari


Description
-------

In one test cluster, the number of packages to install was very large.  This resulted in a timeout of the task.  Odd, since installation of packages is 30 minutes.  Looking at the command json, the timeout for "regular" agent commands was used.

The code was assuming that if the default was LOWER than the command, use the default.  The more conservative approach is to use the higher of the two numbers.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java a13e86d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java de141eb 

Diff: https://reviews.apache.org/r/38501/diff/


Testing
-------

Manual.  Automated pending.


Thanks,

Nate Cole


Re: Review Request 38501: Install of packages for newer HDP version is failing

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38501/#review99563
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Sept. 18, 2015, 5:34 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38501/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 5:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-13150
>     https://issues.apache.org/jira/browse/AMBARI-13150
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In one test cluster, the number of packages to install was very large.  This resulted in a timeout of the task.  Odd, since installation of packages is 30 minutes.  Looking at the command json, the timeout for "regular" agent commands was used.
> 
> The code was assuming that if the default was LOWER than the command, use the default.  The more conservative approach is to use the higher of the two numbers.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java a13e86d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java de141eb 
> 
> Diff: https://reviews.apache.org/r/38501/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 38501: Install of packages for newer HDP version is failing

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38501/#review99570
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Sept. 18, 2015, 1:34 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38501/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 1:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-13150
>     https://issues.apache.org/jira/browse/AMBARI-13150
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In one test cluster, the number of packages to install was very large.  This resulted in a timeout of the task.  Odd, since installation of packages is 30 minutes.  Looking at the command json, the timeout for "regular" agent commands was used.
> 
> The code was assuming that if the default was LOWER than the command, use the default.  The more conservative approach is to use the higher of the two numbers.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java a13e86d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java de141eb 
> 
> Diff: https://reviews.apache.org/r/38501/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 38501: Install of packages for newer HDP version is failing

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38501/
-----------------------------------------------------------

(Updated Sept. 18, 2015, 3:28 p.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-13150
    https://issues.apache.org/jira/browse/AMBARI-13150


Repository: ambari


Description
-------

In one test cluster, the number of packages to install was very large.  This resulted in a timeout of the task.  Odd, since installation of packages is 30 minutes.  Looking at the command json, the timeout for "regular" agent commands was used.

The code was assuming that if the default was LOWER than the command, use the default.  The more conservative approach is to use the higher of the two numbers.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java a13e86d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java de141eb 

Diff: https://reviews.apache.org/r/38501/diff/


Testing (updated)
-------

Manual testing.  Automated:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:12 h
[INFO] Finished at: 2015-09-18T15:25:45-04:00
[INFO] Final Memory: 37M/849M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole