You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/04 09:55:00 UTC

[GitHub] [flink] nicoweidner commented on a change in pull request #17398: [FLINK-24357][tests] Harden ZooKeeperLeaderElectionConnectionHandlingTest

nicoweidner commented on a change in pull request #17398:
URL: https://github.com/apache/flink/pull/17398#discussion_r721212113



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionConnectionHandlingTest.java
##########
@@ -131,7 +130,8 @@ private void runTestWithZooKeeperConnectionProblem(
             Problem problem)
             throws Exception {
         CuratorFramework client =
-                ZooKeeperUtils.startCuratorFramework(configuration, NoOpFatalErrorHandler.INSTANCE);

Review comment:
       Before this change, `fatalErrorHandlerResource.getFatalErrorHandler()` was not even used in the test. I don't quite understand why it even caught the exception in the first place. Did it trigger implicitly somewhere?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org