You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Chris Heller <he...@gmail.com> on 2014/08/06 21:34:09 UTC
Review Request 24407: Use curl-config to locate lib curl when possible
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS.
To work around this we can use curl-config to provide the needed path and link options to the compiler.
This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible.
Diffs
-----
configure.ac a9cc6df
Diff: https://reviews.apache.org/r/24407/diff/
Testing
-------
Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS.
Thanks,
Chris Heller
Re: Review Request 24407: Use curl-config to locate lib curl when possible
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 8, 2014, 6:31 p.m., Timothy St. Clair wrote:
> > why not follow the prefix pattern if it's in a non-standard location --with-curl=/my/custom/path?
>
> Chris Heller wrote:
> I have no problem with that suggestion. I've created a new patch which adds --with-curl (and also supports --with-sasl2 and --with-zlib). Would it be OK to attach the patch to this review, or is it better to close this out and submit again?
Feel free to attach to update the patch to this review for the curl mod, then we can create a JIRA and update for the other dep(s).
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/#review50057
-----------------------------------------------------------
On Aug. 6, 2014, 7:37 p.m., Chris Heller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24407/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 7:37 p.m.)
>
>
> Review request for mesos and Timothy St. Clair.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS.
>
> To work around this we can use curl-config to provide the needed path and link options to the compiler.
>
> This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible.
>
>
> Diffs
> -----
>
> configure.ac a9cc6df
>
> Diff: https://reviews.apache.org/r/24407/diff/
>
>
> Testing
> -------
>
> Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS.
>
>
> Thanks,
>
> Chris Heller
>
>
Re: Review Request 24407: Use curl-config to locate lib curl when possible
Posted by Chris Heller <he...@gmail.com>.
> On Aug. 8, 2014, 6:31 p.m., Timothy St. Clair wrote:
> > why not follow the prefix pattern if it's in a non-standard location --with-curl=/my/custom/path?
I have no problem with that suggestion. I've created a new patch which adds --with-curl (and also supports --with-sasl2 and --with-zlib). Would it be OK to attach the patch to this review, or is it better to close this out and submit again?
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/#review50057
-----------------------------------------------------------
On Aug. 6, 2014, 7:37 p.m., Chris Heller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24407/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 7:37 p.m.)
>
>
> Review request for mesos and Timothy St. Clair.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS.
>
> To work around this we can use curl-config to provide the needed path and link options to the compiler.
>
> This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible.
>
>
> Diffs
> -----
>
> configure.ac a9cc6df
>
> Diff: https://reviews.apache.org/r/24407/diff/
>
>
> Testing
> -------
>
> Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS.
>
>
> Thanks,
>
> Chris Heller
>
>
Re: Review Request 24407: Use curl-config to locate lib curl when possible
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/#review50057
-----------------------------------------------------------
why not follow the prefix pattern if it's in a non-standard location --with-curl=/my/custom/path?
- Timothy St. Clair
On Aug. 6, 2014, 7:37 p.m., Chris Heller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24407/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 7:37 p.m.)
>
>
> Review request for mesos and Timothy St. Clair.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS.
>
> To work around this we can use curl-config to provide the needed path and link options to the compiler.
>
> This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible.
>
>
> Diffs
> -----
>
> configure.ac a9cc6df
>
> Diff: https://reviews.apache.org/r/24407/diff/
>
>
> Testing
> -------
>
> Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS.
>
>
> Thanks,
>
> Chris Heller
>
>
Re: Review Request 24407: Use curl-config to locate lib curl when
possible
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 26, 2014, 12:56 a.m., Timothy St. Clair wrote:
> > Sorry for the lag, I'm still catching up post #MesosCon
You can mark as submitted.
commit a56be86b950c2f64fa98d7f55488afbc7c68e468
Author: Chris Heller <he...@gmail.com>
Date: Tue Aug 26 11:08:01 2014 -0500
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/#review51474
-----------------------------------------------------------
On Aug. 15, 2014, 9:14 p.m., Chris Heller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24407/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 9:14 p.m.)
>
>
> Review request for mesos and Timothy St. Clair.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS.
>
> To work around this we can use curl-config to provide the needed path and link options to the compiler.
>
> This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible.
>
>
> Diffs
> -----
>
> configure.ac 87bfb7e
>
> Diff: https://reviews.apache.org/r/24407/diff/
>
>
> Testing
> -------
>
> Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS.
>
>
> File Attachments
> ----------------
>
> Add --with-curl, --with-sasl2, --with-zlib to configure
> https://reviews.apache.org/media/uploaded/files/2014/08/11/32382e61-68c9-44d4-8a39-a80c3f9e24e1__0000_configure_with_libs.patch
>
>
> Thanks,
>
> Chris Heller
>
>
Re: Review Request 24407: Use curl-config to locate lib curl when
possible
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/#review51474
-----------------------------------------------------------
Ship it!
Sorry for the lag, I'm still catching up post #MesosCon
- Timothy St. Clair
On Aug. 15, 2014, 9:14 p.m., Chris Heller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24407/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 9:14 p.m.)
>
>
> Review request for mesos and Timothy St. Clair.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS.
>
> To work around this we can use curl-config to provide the needed path and link options to the compiler.
>
> This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible.
>
>
> Diffs
> -----
>
> configure.ac 87bfb7e
>
> Diff: https://reviews.apache.org/r/24407/diff/
>
>
> Testing
> -------
>
> Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS.
>
>
> File Attachments
> ----------------
>
> Add --with-curl, --with-sasl2, --with-zlib to configure
> https://reviews.apache.org/media/uploaded/files/2014/08/11/32382e61-68c9-44d4-8a39-a80c3f9e24e1__0000_configure_with_libs.patch
>
>
> Thanks,
>
> Chris Heller
>
>
Re: Review Request 24407: Use curl-config to locate lib curl when
possible
Posted by Chris Heller <he...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/
-----------------------------------------------------------
(Updated Aug. 15, 2014, 9:14 p.m.)
Review request for mesos and Timothy St. Clair.
Changes
-------
Adds flags to provide locations of curl, sasl2, and zlib libraries.
Flags append to CPPFLAGS and LDFLAGS with given path plus appropriate /include or /lib.
Includes help text for flags.
Repository: mesos-git
Description (updated)
-------
If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS.
To work around this we can use curl-config to provide the needed path and link options to the compiler.
This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible.
Diffs (updated)
-----
configure.ac 87bfb7e
Diff: https://reviews.apache.org/r/24407/diff/
Testing
-------
Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS.
File Attachments
----------------
Add --with-curl, --with-sasl2, --with-zlib to configure
https://reviews.apache.org/media/uploaded/files/2014/08/11/32382e61-68c9-44d4-8a39-a80c3f9e24e1__0000_configure_with_libs.patch
Thanks,
Chris Heller
Re: Review Request 24407: Use curl-config to locate lib curl when possible
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/#review50460
-----------------------------------------------------------
The option description needs to be added e.g. -
AC_ARG_WITH([glog],
AS_HELP_STRING([--with-glog@<:@=DIR@:>@],
[excludes building and using the bundled glog
package in lieu of an installed version at a
location prefixed by the given path]),
[without_bundled_glog=yes], [])
Also, you can update the patch via "Update->Update Diff"
- Timothy St. Clair
On Aug. 11, 2014, 7:28 p.m., Chris Heller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24407/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 7:28 p.m.)
>
>
> Review request for mesos and Timothy St. Clair.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS.
>
> To work around this we can use curl-config to provide the needed path and link options to the compiler.
>
> This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible.
>
>
> Diffs
> -----
>
> configure.ac a9cc6df
>
> Diff: https://reviews.apache.org/r/24407/diff/
>
>
> Testing
> -------
>
> Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS.
>
>
> File Attachments
> ----------------
>
> Add --with-curl, --with-sasl2, --with-zlib to configure
> https://reviews.apache.org/media/uploaded/files/2014/08/11/32382e61-68c9-44d4-8a39-a80c3f9e24e1__0000_configure_with_libs.patch
>
>
> Thanks,
>
> Chris Heller
>
>
Re: Review Request 24407: Use curl-config to locate lib curl when possible
Posted by Chris Heller <he...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/
-----------------------------------------------------------
(Updated Aug. 11, 2014, 7:28 p.m.)
Review request for mesos and Timothy St. Clair.
Changes
-------
Adds --with-xxx flags for required libs: curl, sasl2 and zlib. These flags can be used to point to non-standard paths when in use.
Repository: mesos-git
Description
-------
If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS.
To work around this we can use curl-config to provide the needed path and link options to the compiler.
This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible.
Diffs
-----
configure.ac a9cc6df
Diff: https://reviews.apache.org/r/24407/diff/
Testing
-------
Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS.
File Attachments (updated)
----------------
Add --with-curl, --with-sasl2, --with-zlib to configure
https://reviews.apache.org/media/uploaded/files/2014/08/11/32382e61-68c9-44d4-8a39-a80c3f9e24e1__0000_configure_with_libs.patch
Thanks,
Chris Heller
Re: Review Request 24407: Use curl-config to locate lib curl when possible
Posted by Chris Heller <he...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 7:37 p.m.)
Review request for mesos and Timothy St. Clair.
Changes
-------
@tim: can you shepherd this? @vinodkone
Repository: mesos-git
Description
-------
If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS.
To work around this we can use curl-config to provide the needed path and link options to the compiler.
This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible.
Diffs
-----
configure.ac a9cc6df
Diff: https://reviews.apache.org/r/24407/diff/
Testing
-------
Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS.
Thanks,
Chris Heller