[jira] [Created] (OPENNLP-1940) Add missing ASF headers and make RAT fail on unapproved files

["Richard Zowalla (Jira)" <ji...@apache.org>]

Richard Zowalla created OPENNLP-1940:
----------------------------------------

             Summary: Add missing ASF headers and make RAT fail on unapproved files
                 Key: OPENNLP-1940
                 URL: https://issues.apache.org/jira/browse/OPENNLP-1940
             Project: OpenNLP
          Issue Type: Improvement
          Components: Build, Packaging and Test
            Reporter: Richard Zowalla
             Fix For: 3.0.0


Found while verifying 3.0.0\-M6 RC1 \(non\-blocking, same state as in 3.0.0\-M5\).

The following files in the source release have no ASF license header:* {{opennlp\-core/pom.xml}}
* {{opennlp\-core/opennlp\-cli/pom.xml}}
* {{opennlp\-core/opennlp\-formats/pom.xml}}
* {{opennlp\-core/opennlp\-runtime/pom.xml}}
* {{opennlp\-core/opennlp\-ml/opennlp\-dl/README.md}}
* {{opennlp\-core/opennlp\-ml/opennlp\-dl\-gpu/README.md}}
* {{opennlp\-core/opennlp\-runtime/BENCHMARKS.md}}
* {{opennlp\-distr/README\_FOOTER.html}}
* {{opennlp\-distr/src/main/docker/Dockerfile}}

These are not caught because the root {{pom.xml}} configures {{apache\-rat\-plugin}} with {{numUnapprovedLicenses=1000000}}, so {{apache\-rat:check}} never fails. Also, many patterns in {{rat\-excludes}} \(e.g. {{src/test/resources/opennlp/tools/_/_.txt}}\) no longer match after the module restructuring into {{opennlp\-core/...}} and {{opennlp\-extensions/...}}, so RAT reports \~188 unapproved files \(mostly test data\), which hides real findings like the ones above. Even with {{\-Papache\-release}} the report is not clean.

Proposed fix:
\* Add ASF headers to the files listed above.
\* Update {{rat\-excludes}} to match the current module layout \(test data, head rules, third\-party Snowball/stopword/Unicode files, which are already covered by LICENSE/NOTICE\).
\* Remove {{numUnapprovedLicenses=1000000}} so RAT fails the build on new unapproved files.





--
This message was sent by Atlassian Jira
(v8.20.10#820010)