[GitHub] [superset] michael-s-molina commented on a diff in pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards

[GitBox <gi...@apache.org>]

michael-s-molina commented on code in PR #22364:
URL: https://github.com/apache/superset/pull/22364#discussion_r1043732427


##########
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx:
##########
@@ -204,6 +205,13 @@ jest.mock('@superset-ui/core', () => ({
   }),
 }));
 
+jest.mock(

Review Comment:
   Given that our icons load asynchronously, you can either mock the icons as you did or wait for them to render. We generally mock them when they're not the focus of the tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org