You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/03/01 03:38:33 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #8275: [community] Modify doris connector release doc
morningman opened a new pull request #8275:
URL: https://github.com/apache/incubator-doris/pull/8275
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Modify some comment
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8275: [community] Modify doris connector release doc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8275:
URL: https://github.com/apache/incubator-doris/pull/8275#issuecomment-1059756641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8275: [community] Modify doris connector release doc
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #8275:
URL: https://github.com/apache/incubator-doris/pull/8275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8275: [community] Modify doris connector release doc
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #8275:
URL: https://github.com/apache/incubator-doris/pull/8275#discussion_r816428257
##########
File path: docs/en/community/release-and-verify/release-doris-connectors.md
##########
@@ -71,17 +78,17 @@ Execute the following command to start generating the release tag.
```bash
cd flink-doris-connector/
-mvn release:clean -DreleaseArgs="-Dflink.version=1.13.5 -Dscala.version=2.12" -Dflink.version=1.13.5 -Dscala.version=2.12
-mvn release:prepare -DreleaseArgs="-Dflink.version=1.13.5 -Dscala.version=2.12" -Dflink.version=1.13.5 -Dscala.version=2.12 -DpushChanges=false
+mvn release:clean
+mvn release:prepare -DpushChanges=false
```
where `-DpushChanges=false` means that the newly generated branches and tags are not pushed to the codebase during execution.
After executing the `release:prepare` command, the following three pieces of information will be requested.
-1. the version of the Doris Flink Connector, which we can do by default, either by entering a carriage return or by typing in the version you want. The version format is `{flink.version}-{scala.version}-{connector.version}`, e.g. `1.13.5-2.12-1.0.0`. 2.
-2. The release tag of Doris Flink Connector, the release process will generate a tag locally, we can use the default tag name, such as `1.13.5-2.12-1.0.0`.
-3. The version number of the next version of Doris Flink Connector. This version number is only used for generating local branches and has no real meaning. For example, if the current release is `1.13.5-2.12-1.0.0`, then the next version number should be `1.13.5-2.12-1.0.1`.
+1. the version of the Doris Flink Connector: which we can do by default, either by entering a carriage return or by typing in the version you want. The version format is `{flink.version}-{scala.version}-{connector.version}`, e.g. `1.13.5-2.12-1.0.0`. 2.
Review comment:
```suggestion
1. the version of the Doris Flink Connector: which we can do by default, either by entering a carriage return or by typing in the version you want. The version format is `{flink.version}-{scala.version}-{connector.version}`, e.g. `1.13.5-2.12-1.0.0`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8275: [community] Modify doris connector release doc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8275:
URL: https://github.com/apache/incubator-doris/pull/8275#issuecomment-1059887119
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org