[GitHub] [incubator-superset] aspedrosa opened a new issue #8501: Still fetching fav-star data when no user is logged in

[GitBox <gi...@apache.org>]

aspedrosa opened a new issue #8501: Still fetching fav-star data when no user is logged in
URL: https://github.com/apache/incubator-superset/issues/8501
 
 
   By giving the permissions:
   - can dashboard on Superset
   - can csrf token on Superset
   - can explore json on Superset
   - can list on CssTemplateAsyncModelView
   - all datasource access on all_datasource_access
   
   to the public role, any non logged in user can explore any dashboard. However, even with no user logged in, frontend app still tries to fetch the favorite status of the current dashboard.
   
   ### Expected results
   
   Verify if a user is logged in and only if it is then fetch the favorite status of the current dashboard.
   
   ### Actual results
   
   The favorite status of the current dashboard is always fetched
   
   #### Screenshots
   
   ![fav-start-showing](https://user-images.githubusercontent.com/23409890/68135502-a93c1e00-ff1b-11e9-8214-4f80108d84a0.png)
   
   #### How to reproduce the bug
   
   1. Give the permissions mentioned on the beggining of the issue to the public role
   2. Log out
   3. Go to the url of any dashboard
   4. See toast and fav-start still showing
   
   ### Environment
   
   - using docker on commit [[SIP-15] Updating ISO 8601 regex match to make time optional (#8494) ](https://github.com/apache/incubator-superset/commit/fda2333cf21c2d71ad0ca276f78fd4b5b6fef314)
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [X] I have reproduced the issue with at least the latest released version of superset.
   - [X] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org