You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/07 20:40:47 UTC
[GitHub] [iceberg] InvisibleProgrammer opened a new pull request, #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
InvisibleProgrammer opened a new pull request, #6379:
URL: https://github.com/apache/iceberg/pull/6379
Docs: Update Iceberg Hive documentation - 1.0.x
(cherry picked from commit 5b1505378414295476a73e07aca65fdb1a29da7d)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1342088608
There won't be any release from the 1.0.x branch. So, this backport is not really required.
Keeping the fix in the master branch is enough. The next 1.2.0 release will be from the master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#discussion_r1051685815
##########
docs/hive.md:
##########
@@ -244,7 +254,7 @@ The result is:
| j | IDENTITY | NULL
You can create Iceberg partitions using the following Iceberg partition specification syntax
-(supported only in Hive 4.0.0-alpha-1):
+(supported only from Hive 4.0.0-alpha-1):
Review Comment:
How does this create partitions? Is this trying to say you can alter partition fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1342521379
> Does this mean, that we will never release an 1.0.1? Even if we find a log4j level serious issue?
I have not seen this case, might just release a new version of the last release. (ex: 1.1.1), but may not be for 1.0.X or older.
@Fokko or other previous release owners can answer this may be.
> Does this mean, that if we want to update the current documentation (both for current and older releases) we need to create a pull request for https://github.com/apache/iceberg-docs?
There are two kinds of docs, one that is in `iceberg` repo and one that is in `iceberg-docs `repo.
`iceberg-docs` repo has some site-related extra docs and it also refers to `iceberg` repo docs. The release owner creates branches in `iceberg-docs ` repo. So we need to raise PR wherever our `.md` file is present related to that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#discussion_r1051685890
##########
docs/hive.md:
##########
@@ -433,6 +449,15 @@ Tables can be dropped using the `DROP TABLE` command:
DROP TABLE [IF EXISTS] table_name [PURGE];
```
+### METADATA LOCATION
Review Comment:
What is the value of this? Is it used for something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] InvisibleProgrammer commented on pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
InvisibleProgrammer commented on PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1356327476
Hey there!
With the help of @pvary , all updates for the older releases are merged.
I wonder, do you know what is the process of releasing the merged changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1342581926
> > Does this mean, that if we want to update the current documentation (both for current and older releases) we need to create a pull request for https://github.com/apache/iceberg-docs?
>
> There are two kinds of docs, one that is in `iceberg` repo and one that is in `iceberg-docs `repo. `iceberg-docs` repo has some site-related extra docs and it also refers to `iceberg` repo docs. The release owner creates branches in `iceberg-docs ` repo. So we need to raise PR wherever our `.md` file is present related to that change.
I see these hive related files in the docs repo:
- https://github.com/apache/iceberg-docs/blob/1.1.0/docs/content/hive.md
- https://github.com/apache/iceberg-docs/blob/latest/docs/content/hive.md
- https://github.com/apache/iceberg-docs/blob/1.0.0/docs/content/hive.md
- https://github.com/apache/iceberg-docs/blob/0.14.1/docs/content/hive.md
If my understanding is correct, updating these should update the current documentation on the iceberg.apache.org site.
Since this is not some code related change, but mostly "infrastructure" around Iceberg, I think it is reasonable to update it on at least update on the latest/1.1.0 branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#discussion_r1051685991
##########
docs/hive.md:
##########
@@ -509,7 +534,15 @@ SELECT * FROM table_a FOR SYSTEM_TIME AS OF '2021-08-09 10:35:57';
SELECT * FROM table_a FOR SYSTEM_VERSION AS OF 1234567;
```
-## Type compatibility
+You can expire snapshots of an Iceberg table using an ALTER TABLE query from Hive. You should periodically expire snapshots to delete data files that is no longer needed, and reduce the size of table metadata.
Review Comment:
I think this needs a section heading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#discussion_r1051685727
##########
docs/hive.md:
##########
@@ -38,6 +38,16 @@ Iceberg compatibility with Hive 2.x and Hive 3.1.2/3 supports the following feat
DML operations work only with MapReduce execution engine.
{{< /hint >}}
+With Hive version 4.0.0-alpha-2 and above,
Review Comment:
Why does this refer to an alpha release? I think we should only reference official Hive releases, and probably not alpha ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] InvisibleProgrammer commented on pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
InvisibleProgrammer commented on PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1342756436
For me, the documentation of iceberg-docs is a little bit misleading:
```
Changes to the markdown contents for version specific pages should be submitted directly in the Iceberg repository.
...
Changes to the documentation of old Iceberg versions should be submitted to this repository against the specific version branch.
```
Anyway, let me try updating the version folders in iceberg-docs.
Thank you for the clarification,
Zsolt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on a diff in pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#discussion_r1051837704
##########
docs/hive.md:
##########
@@ -38,6 +38,16 @@ Iceberg compatibility with Hive 2.x and Hive 3.1.2/3 supports the following feat
DML operations work only with MapReduce execution engine.
{{< /hint >}}
+With Hive version 4.0.0-alpha-2 and above,
Review Comment:
Hive is pushing for the final release. There were no new releases for a few years now, but the community started to finalize one. And one of the main feature there is the native Iceberg support which is not there with older releases. We need to notify the commit about the new features to gather feedback and fix issues for the final release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] InvisibleProgrammer commented on a diff in pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
InvisibleProgrammer commented on code in PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#discussion_r1059790864
##########
docs/hive.md:
##########
@@ -244,7 +254,7 @@ The result is:
| j | IDENTITY | NULL
You can create Iceberg partitions using the following Iceberg partition specification syntax
-(supported only in Hive 4.0.0-alpha-1):
+(supported only from Hive 4.0.0-alpha-1):
Review Comment:
I wouldn't say that. It is about creating a table, not altering one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1342412663
@ajantha-bhat: 2 questions:
- Does this mean, that we will never release an 1.0.1? Even if we find a `log4j` level serious issue?
- Does this mean, that if we want to update the current documentation (both for current and older releases) we need to create a pull request for https://github.com/apache/iceberg-docs?
Thanks,
Peter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] InvisibleProgrammer commented on pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
InvisibleProgrammer commented on PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1355156829
I think I've found the proper way to update the documentation for older versions. What do you think, is that the correct way?
- 0.14.1: https://github.com/apache/iceberg-docs/pull/188
- 1.0.0: https://github.com/apache/iceberg-docs/pull/189
- 1.1.0: https://github.com/apache/iceberg-docs/pull/190
Thank you,
Zsolt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] InvisibleProgrammer commented on pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
InvisibleProgrammer commented on PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1341578681
1.0.x port of https://github.com/apache/iceberg/pull/6337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] InvisibleProgrammer commented on pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
InvisibleProgrammer commented on PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1342349355
@ajantha-bhat, I understand that there will be no release on a released version of Iceberg. Also, I want to understand why it is not recommended to update the documentation. Does the documentation have a release flow separated from the Iceberg code or it can be released only as a whole package? And I wonder, what is the reason behind freezing the documentation?
Does it mean that for the future release, we must document everything upfront?
Thank you,
Zsolt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1342369999
Because we deploy only the current version and next version docs.
more info here:
https://iceberg.apache.org/how-to-release/#documentation-release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] InvisibleProgrammer commented on a diff in pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
InvisibleProgrammer commented on code in PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#discussion_r1052416758
##########
docs/hive.md:
##########
@@ -38,6 +38,16 @@ Iceberg compatibility with Hive 2.x and Hive 3.1.2/3 supports the following feat
DML operations work only with MapReduce execution engine.
{{< /hint >}}
+With Hive version 4.0.0-alpha-2 and above,
Review Comment:
I agree. I suppose it was the same intention when the doc was updated with the alpha-1 changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] InvisibleProgrammer closed pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
Posted by GitBox <gi...@apache.org>.
InvisibleProgrammer closed pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)
URL: https://github.com/apache/iceberg/pull/6379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org