[GitHub] [doris-thirdparty] airborne12 commented on a diff in pull request #113: [Optimize](search) Optimize implement the new query interface

["airborne12 (via GitHub)" <gi...@apache.org>]

airborne12 commented on code in PR #113:
URL: https://github.com/apache/doris-thirdparty/pull/113#discussion_r1301627516


##########
src/core/CLucene/search/IndexSearcher.cpp:
##########
@@ -59,15 +59,22 @@ CL_NS_DEF(search)
     	}
 	};
 
-    class AllTopDocsCollector:public HitCollector {
-        public:
-            AllTopDocsCollector(const Functor& cb) : cb_(cb) {}
-            void collect(const int32_t doc, const float_t score) {
-                cb_(doc, score);
-            }
+    class AllTopDocsCollector : public HitCollector {
+      public:
+        AllTopDocsCollector(const Functor& cb) : cb_(cb) {}
+        AllTopDocsCollector(const DocRangeFunctor& range_cb) : range_cb_(range_cb) {} 

Review Comment:
   may be some test code need for new collector



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org