[jira] [Commented] (ORC-266) [C++] A few issues with cmake scripts and non-vendored third party libraries

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263411#comment-16263411 ] 

ASF GitHub Bot commented on ORC-266:
------------------------------------

Github user jcrist commented on a diff in the pull request:

    https://github.com/apache/orc/pull/192#discussion_r152686927
  
    --- Diff: cmake_modules/ThirdpartyToolchain.cmake ---
    @@ -41,32 +68,35 @@ if (NOT SNAPPY_FOUND)
         LOG_BUILD 1
         LOG_INSTALL 1
         BUILD_BYPRODUCTS "${SNAPPY_STATIC_LIB}")
    +
    +  set (SNAPPY_VENDORED TRUE)
     endif ()
    -include_directories (SYSTEM ${SNAPPY_INCLUDE_DIRS})
    +
    +include_directories (SYSTEM ${SNAPPY_INCLUDE_DIR})
     add_library (snappy STATIC IMPORTED)
     set_target_properties (snappy PROPERTIES IMPORTED_LOCATION ${SNAPPY_STATIC_LIB})
    -set (SNAPPY_LIBRARIES snappy)
    -add_dependencies (snappy snappy_ep)
    -install(DIRECTORY ${SNAPPY_PREFIX}/lib DESTINATION .
    --- End diff --
    
    Done. Went with `INSTALL_VENDORED_LIBS`, which defaults to on.


> [C++] A few issues with cmake scripts and non-vendored third party libraries
> ----------------------------------------------------------------------------
>
>                 Key: ORC-266
>                 URL: https://issues.apache.org/jira/browse/ORC-266
>             Project: ORC
>          Issue Type: Bug
>          Components: C++
>            Reporter: Jim Crist
>            Assignee: Jim Crist
>
> Currently there are a few issues with the cmake build system:
> - Running `make install` (or `make package`) when using any non-vendored third party library results in copying all files not matching `"*.so|*.dylib"` from the `*_HOME/lib` directory into the `lib/` directory. This is because third party libraries are being installed via a filter instead of specific file paths. This is definitely a bug.
> - There is no easy way to specify third party library locations when using orc as an `ExternalProject` in another cmake project. This is easily fixed by separating the defining of `*_HOME` variables from their use, which allows e.g. `-DSNAPPY_HOME=...` to work.
> - There is no way to avoid building the tests
> - There is no way to avoid building the tools
> - The LICENSE and NOTICE get installed into the root directory, which is not where they should go. Since the header files all contain the license header, and other apache projects don't install the license, the lines installing these files should be removable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)