You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/18 03:55:59 UTC
[GitHub] [skywalking] hanahmily opened a new issue #6029: [OPERATOR]Agent injection webhook
hanahmily opened a new issue #6029:
URL: https://github.com/apache/skywalking/issues/6029
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [x] Feature or performance improvement
___
### Requirement or improvement
SWCK operator supports provisioning skywalking backends to a kubernetes cluster. However, the agent that generally refer to java, C#, python, and nodejs automatic instruments is the last piece of the puzzle.
After a long period of discussion and investigation, we have a plan to introduce a new webhook to inject agent images to workload pods **automatically**(by the **`operator`**) or **manually**(by **`swctl`**).
A canonical path to trigger auto-injection is to insert dedicated **annotations** to workloads and namespaces, then **`operator`** intercepts the provision of their pods, injecting agent relevant pieces into pod template. The result of injection might like below:
<img width="653" alt="WechatIMG62" src="https://user-images.githubusercontent.com/1960537/102572664-a7d1b300-4127-11eb-8b11-bbf852cb39cb.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kagaya85 commented on issue #6029: [OPERATOR]Agent injection webhook
Posted by GitBox <gi...@apache.org>.
kagaya85 commented on issue #6029:
URL: https://github.com/apache/skywalking/issues/6029#issuecomment-849353646
Hi there, I am interested in this issue and would like to participate in contributing code to SkyWalking through the opensource summer 2021 project. I prepared a technical proposal and wanted to further discuss the specific implementation with mentor of this issue. I tried to send an email but didn't get a reply, thanks very much if someone could tell me how to get involved in the work😀.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6029: [OPERATOR]Agent injection webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6029:
URL: https://github.com/apache/skywalking/issues/6029#issuecomment-747880707
If the docker file is never voted, then images can't be pushed as it is not an official release source codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on issue #6029: [OPERATOR]Agent injection webhook
Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #6029:
URL: https://github.com/apache/skywalking/issues/6029#issuecomment-849362362
@kagaya85 I have not received messages from you. Since several students who want to join iscas have contacted with me, you seem to send the wrong address. My mail address is `hanahmily@apache.org` or `hanahmily@gmail.com`.
We could discuss the details through the mail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kagaya85 commented on issue #6029: [OPERATOR]Agent injection webhook
Posted by GitBox <gi...@apache.org>.
kagaya85 commented on issue #6029:
URL: https://github.com/apache/skywalking/issues/6029#issuecomment-849369984
@hanahmily Thank you very much, I will try again to submit my application.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6029: [OPERATOR]Agent injection webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6029:
URL: https://github.com/apache/skywalking/issues/6029#issuecomment-747863097
The key is you need to adjust main repo docker file, to make sure they are voted in the release. Your mentioned things are after release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #6029: [OPERATOR]Agent injection webhook
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #6029:
URL: https://github.com/apache/skywalking/issues/6029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on issue #6029: [OPERATOR]Agent injection webhook
Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #6029:
URL: https://github.com/apache/skywalking/issues/6029#issuecomment-747872959
> The key is you need to adjust main repo docker file...
I didn't find any reason to introduce the agent docker file into the main repo. The E2E of webhook will be added into `swck` repo with the agent docker image built from a released agent version.
Even though we submit it into the main repo, it seems nothing special should be taken care of in the release vote process? If I missed something, feel free to correct me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6029: [OPERATOR]Agent injection webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6029:
URL: https://github.com/apache/skywalking/issues/6029#issuecomment-748581821
> I didn't find any reason to introduce the agent docker file into the main repo.
Only reason is, this image will need to push with every release. This is a requirement from a release vote perspective.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on issue #6029: [OPERATOR]Agent injection webhook
Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #6029:
URL: https://github.com/apache/skywalking/issues/6029#issuecomment-747853962
> Does this mean, we are going to release agent images separately? If so, seems there are several things to adjust the release processes and docker files.
Exactly. The basic idea of images is to follow the backend convention. That means putting agent manifests into the `skywalking-docker` repo, releasing agent images as one step of the entire image release process, documenting the new images on the `README.md` of `skywalking-docker`, the official docker hub repo and skywalking website.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #6029: [OPERATOR]Agent injection webhook
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #6029:
URL: https://github.com/apache/skywalking/issues/6029#issuecomment-920590325
Resolved by https://github.com/apache/skywalking-swck/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6029: [OPERATOR]Agent injection webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6029:
URL: https://github.com/apache/skywalking/issues/6029#issuecomment-849354358
@hanahmily I think it is on your hands, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6029: [OPERATOR]Agent injection webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6029:
URL: https://github.com/apache/skywalking/issues/6029#issuecomment-747852529
Does this mean, we are going to release agent images separately? If so, seems there are several things to adjust the release processes and docker files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org