You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "zstan (via GitHub)" <gi...@apache.org> on 2023/08/11 17:11:43 UTC

[GitHub] [ignite-3] zstan commented on a diff in pull request #2435: IGNITE-20192 Fix default length for variable-length columns

zstan commented on code in PR #2435:
URL: https://github.com/apache/ignite-3/pull/2435#discussion_r1291603088


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/PlatformTestNodeRunner.java:
##########
@@ -271,7 +271,7 @@ private static void createTables(Ignite node) {
                 SchemaConfigurationConverter.convert(schTbl, tblCh)
         ));
 
-        int maxTimePrecision = TemporalColumnType.MAX_TIME_PRECISION;
+        int maxTimePrecision = CatalogUtils.MAX_TIME_PRECISION;

Review Comment:
   but TemporalColumnType.MAX_TIME_PRECISION; still used, why do we need it ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org