[GitHub] [ozone] GeorgeJahad commented on pull request #5106: HDDS-9063. OM - Recon unable to obtain Ozone Manager DB Snapshot

["GeorgeJahad (via GitHub)" <gi...@apache.org>]

GeorgeJahad commented on PR #5106:
URL: https://github.com/apache/ozone/pull/5106#issuecomment-1648401464

   With the exception of the npe comment above, this looks good to me.  FYI @smengcl I wrote most of this patch after @devmadhuu  pointed out the problem to me from a real cluster.  He then kindly tested it to confirm the fix, created the PR and fixed the findbugs issues.
   
   Thanks for all the help Devesh!
   
   Given that I wrote most of it, we should probably get one more person to approve it, but it is a relatively safe, and important fix, so I will merge it tomorrow morning if no one else has time to review it before then.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org