You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Ian Cook (Jira)" <ji...@apache.org> on 2021/02/26 21:38:00 UTC
[jira] [Updated] (ARROW-11801) [C++] Remove bad header guard in
filesystem/type_fwd.h
[ https://issues.apache.org/jira/browse/ARROW-11801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Cook updated ARROW-11801:
-----------------------------
Description:
There is an {{#if defined(ARROW_R_WITH_S3)}} here in {{cpp/src/arrow/filesystem/type_fwd.h}}:
[https://github.com/apache/arrow/commit/b058cf0d1c26ad7984c104bb84322cc7dcc66f00#diff-be848bca05dd0e7f650673782a2[…]9778ca59d674ea64cd639e6a7853e2R47|https://github.com/apache/arrow/commit/b058cf0d1c26ad7984c104bb84322cc7dcc66f00#diff-be848bca05dd0e7f650673782a21a4c2849778ca59d674ea64cd639e6a7853e2R47]
There should not be any of these R-specific guards outside of {{r/src}}. Remove it.
> [C++] Remove bad header guard in filesystem/type_fwd.h
> ------------------------------------------------------
>
> Key: ARROW-11801
> URL: https://issues.apache.org/jira/browse/ARROW-11801
> Project: Apache Arrow
> Issue Type: Task
> Components: C++
> Affects Versions: 3.0.0
> Reporter: Ian Cook
> Assignee: Ian Cook
> Priority: Major
> Fix For: 4.0.0
>
>
> There is an {{#if defined(ARROW_R_WITH_S3)}} here in {{cpp/src/arrow/filesystem/type_fwd.h}}:
> [https://github.com/apache/arrow/commit/b058cf0d1c26ad7984c104bb84322cc7dcc66f00#diff-be848bca05dd0e7f650673782a2[…]9778ca59d674ea64cd639e6a7853e2R47|https://github.com/apache/arrow/commit/b058cf0d1c26ad7984c104bb84322cc7dcc66f00#diff-be848bca05dd0e7f650673782a21a4c2849778ca59d674ea64cd639e6a7853e2R47]
> There should not be any of these R-specific guards outside of {{r/src}}. Remove it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)