You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vruusmann <gi...@git.apache.org> on 2016/05/25 09:02:47 UTC

[GitHub] spark pull request: [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.1...

GitHub user vruusmann opened a pull request:

    https://github.com/apache/spark/pull/13293

    [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.15

    ## What changes were proposed in this pull request?
    
    See https://issues.apache.org/jira/browse/SPARK-15523
    
    ## How was this patch tested?
    
    Executed `mvn clean package` in `spark/mllib` directory.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vruusmann/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13293.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13293
    
----
commit 614b1690560df144c887ec61d3520bfb685b09e3
Author: Villu Ruusmann <vi...@gmail.com>
Date:   2016-05-25T08:57:14Z

    [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.15

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.1...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/13293#issuecomment-221597567
  
    Jenkins add to whitelist 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.1...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/13293#issuecomment-221597616
  
    Jenkins test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.1...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/13293#issuecomment-221598803
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59279/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.1...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/13293#issuecomment-221598377
  
    You'll need to run dev/test-dependencies to update the deps files. 
    
    Are the exclusions definitely not needed? You would know best. 
    
    Are there any compatibility issues or particular improvement this brings? I generally like keeping this up to date of course. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.1...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/13293#issuecomment-221598223
  
    **[Test build #59279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59279/consoleFull)** for PR 13293 at commit [`614b169`](https://github.com/apache/spark/commit/614b1690560df144c887ec61d3520bfb685b09e3).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.1...

Posted by vruusmann <gi...@git.apache.org>.
Github user vruusmann commented on the pull request:

    https://github.com/apache/spark/pull/13293#issuecomment-221600087
  
    I'll go and read Apache Spark docs about PR guidelines. Looks like I missed this deps thing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.1...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/13293#issuecomment-221516043
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.1...

Posted by vruusmann <gi...@git.apache.org>.
Github user vruusmann closed the pull request at:

    https://github.com/apache/spark/pull/13293


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.1...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/13293#issuecomment-221598797
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15523][ML][MLLIB] Update JPMML to 1.2.1...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/13293#issuecomment-221598788
  
    **[Test build #59279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59279/consoleFull)** for PR 13293 at commit [`614b169`](https://github.com/apache/spark/commit/614b1690560df144c887ec61d3520bfb685b09e3).
     * This patch **fails build dependency tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org