You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/06 17:37:50 UTC

[GitHub] [arrow-rs] viirya commented on issue #2320: optimize the validation of decimal: compare data using the byte array instead of i128 or string

viirya commented on issue #2320:
URL: https://github.com/apache/arrow-rs/issues/2320#issuecomment-1207252895

   Currently we only do decimal validation where:
   
   1. Changing precision/scale by `with_precision_scale`. It is also selective since it does validation only new precision is smaller.
   2. Appending value to decimal builders
   3. Performing full validation on ArrayData
   4. Reading CSV file
   
   I think it is somehow selective right now. Actually we do decimal validation less than necessary, as mentioned above `from_fixed_size_binary_array` doesn't validate input values. We just assume that the inputs are all valid if users use such API do build decimal array.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org