You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2009/04/14 19:49:42 UTC
svn commit: r764901 - in
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal:
services/StaxTemplateParser.java test/TestableRequestImpl.java
Author: hlship
Date: Tue Apr 14 17:49:42 2009
New Revision: 764901
URL: http://svn.apache.org/viewvc?rev=764901&view=rev
Log:
TAP5-644: When using PageTester, an exception in the page is hidden by an exception rendering the exception report page (pt. 2)
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/StaxTemplateParser.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/test/TestableRequestImpl.java
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/StaxTemplateParser.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/StaxTemplateParser.java?rev=764901&r1=764900&r2=764901&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/StaxTemplateParser.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/StaxTemplateParser.java Tue Apr 14 17:49:42 2009
@@ -354,8 +354,7 @@
{
processTextBuffer(initialState);
- TemplateParserState state = checkForXMLSpaceAttribute(initialState);
- return state;
+ return checkForXMLSpaceAttribute(initialState);
}
/**
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/test/TestableRequestImpl.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/test/TestableRequestImpl.java?rev=764901&r1=764900&r2=764901&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/test/TestableRequestImpl.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/test/TestableRequestImpl.java Tue Apr 14 17:49:42 2009
@@ -19,10 +19,7 @@
import org.apache.tapestry5.ioc.internal.util.InternalUtils;
import org.apache.tapestry5.services.Session;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Locale;
-import java.util.Map;
+import java.util.*;
public class TestableRequestImpl implements TestableRequest
{
@@ -49,12 +46,6 @@
this.contextPath = contextPath;
}
- private <T> T nyi(String methodName)
- {
- throw new RuntimeException(
- String.format("Request: method %s() not yet implemented by TestableRequestImpl.", methodName));
- }
-
public TestableRequest clear()
{
parameters.clear();
@@ -112,19 +103,23 @@
public long getDateHeader(String name)
{
- nyi("getDateHeader");
-
return 0;
}
+ /**
+ * Returns null.
+ */
public String getHeader(String name)
{
- return nyi("getHeader");
+ return null;
}
+ /**
+ * Returns an empty list.
+ */
public List<String> getHeaderNames()
{
- return nyi("getHeaderNames");
+ return Collections.emptyList();
}
public Locale getLocale()