You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@eventmesh.apache.org by mi...@apache.org on 2023/02/27 08:37:01 UTC

[incubator-eventmesh] branch master updated: [ISSUE #3271]Fix handle http message throw IllegalReferenceCountException

This is an automated email from the ASF dual-hosted git repository.

mikexue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-eventmesh.git


The following commit(s) were added to refs/heads/master by this push:
     new 3a362753c [ISSUE #3271]Fix handle http message throw IllegalReferenceCountException
     new 3e9b1ee40 Merge pull request #3272 from mxsm/eventmesh-3271
3a362753c is described below

commit 3a362753c43e5fcc36e32e1973e7375a98eb6f2d
Author: mxsm <lj...@gmail.com>
AuthorDate: Sun Feb 26 10:22:25 2023 +0800

    [ISSUE #3271]Fix handle http message throw IllegalReferenceCountException
---
 .../java/org/apache/eventmesh/runtime/boot/AbstractHTTPServer.java   | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/AbstractHTTPServer.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/AbstractHTTPServer.java
index 8a1179ed1..078eaf9cb 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/AbstractHTTPServer.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/AbstractHTTPServer.java
@@ -95,7 +95,6 @@ import io.netty.handler.codec.http.multipart.InterfaceHttpData;
 import io.netty.handler.ssl.SslHandler;
 import io.netty.handler.timeout.IdleState;
 import io.netty.handler.timeout.IdleStateEvent;
-import io.netty.util.ReferenceCountUtil;
 import io.opentelemetry.api.trace.Span;
 import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
 
@@ -444,9 +443,7 @@ public abstract class AbstractHTTPServer extends AbstractRemotingServer {
                 }
 
             } catch (Exception ex) {
-                log.error("AbrstractHTTPServer.HTTPHandler.channelRead error", ex);
-            } finally {
-                ReferenceCountUtil.release(httpRequest);
+                log.error("execute AbstractHTTPServer.HTTPHandler.channelRead0 error", ex);
             }
         }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: commits-help@eventmesh.apache.org