You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "xavier-GitHub76 (via GitHub)" <gi...@apache.org> on 2023/11/15 10:51:04 UTC
[I] Although defined, some elements are not translated [superset]
xavier-GitHub76 opened a new issue, #25988:
URL: https://github.com/apache/superset/issues/25988
Hello,
I had created an issue (https://github.com/apache/superset/issues/21493) but it has multiples cause of no translation.
I specialise this issue on elements not translated although defined
It's not just a lack of traduction
Items are :
- "Dashboards": ["Tableaux de bord"],
- "Charts": ["Graphiques"],
- "Datasets": ["Jeux de données"],
- "Saved Queries": ["Requêtes sauvegardées"],
- "Query History": ["Historiques des requêtes"],
- "Action Log": ["Journaux d'actions"],
- "Annotation layers": ["Couches d'annotations"],
- "CSS template": ["Templates CSS"],
- "Row Level Security": ["Sécurité de niveau ligne"],
- "Alerts & Reports": ["Alertes et rapports"],
- "Refresh": ["Forcer à rafraîchir"],
- "Report name": ["Nom du rapport"],
Screenshot :
The french translation are not applied.
Best regard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "qleroy (via GitHub)" <gi...@apache.org>.
qleroy commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-1902769247
@xavier-GitHub76
I noticed that if you run
pybabel compile -d superset/translations
it will create/update the messages.mo files and then the navbar is correctly translated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "xavier-GitHub76 (via GitHub)" <gi...@apache.org>.
xavier-GitHub76 commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-1812252390
I use Supserset in version 3.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-2108695902
I'm not sure how we ought to handle this, really, but I suspect it's quietly affecting a lot of people that just don't realize it. Should we auto-generate the .mo files again? I'm not sure the advantage/history of why those are currently not included... just file size? I think @mistercrunch knows the history on their removal, but I'm not sure anyone's feelings for or against reintroducing them.
Also curious if people think we should leave this open (since it's kind of a bug) or close this out in favor of the open Discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-2108830247
I wonder if we could even generate them at start time, since (as I recall) they're pretty slow. If we do that, then it's not a breaking change, the repo gets lighter, and the translations will be up to date every time the code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "qleroy (via GitHub)" <gi...@apache.org>.
qleroy commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-1905355376
This is related to the issue
There are no messages.mo files in the docker container so no translations related to FAB !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-2110632816
True... though `npm run build` already takes approximately forever. 10 more seconds there might not be the end of the world, if it catches more use cases and centralizes the task for docker/pypi/local use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-2118889902
My proposal to improve things around translations -> https://github.com/apache/superset/pull/28483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-2115783693
Right, the npm/webpack built assets are indeed included in the python package... which I thought was done via `npm run build` anyway... so it'd just be shifting it to that NPM process. This would just have the benefit for people cloning the repo from github, so they could just run `npm run build` to have the assets in their local builds. Doing so on `npm run dev(-server)` seems a bit heavy-handed, but also seems useful for those contributing translations. The NPM script _might_ even be able to check if you have translations turned on, and only run it if relevant. Maybe this is a good topic to discuss more synchronously :) It'd be great to get it all straightened out one way or another! :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "Ralkion (via GitHub)" <gi...@apache.org>.
Ralkion commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-1813101824
Hi @xavier-GitHub76
I've found that the menu items are populated from the backend, not the front-end. So the translated values must be in the `.mo` file, not the `.json` file.
Hope that helps!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-2741568939
The above PR has merged, and .mo/.json files are now built automatically. Closing this, but happy to revisit if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #25988: Although defined, some elements are not translated
URL: https://github.com/apache/superset/issues/25988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-2108803111
I'm thinking we should add the .mo and .json file build as part of the docker and pypi builds, and keep these files from the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-2110618324
at 10-20 seconds each (pybabel and po2json) I think it's a bit slow to force that on web-server start, plus there are many ways to start the web server, and many people don't care for all or some of the translations...
I think this fits perfectly in a docker build and/or pypi build steps, though it does add a bit of weights to the images/bundles (about 8mb) which I think is totally fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Although defined, some elements are not translated [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #25988:
URL: https://github.com/apache/superset/issues/25988#issuecomment-2111578945
Wait but the built frontend assets are bundled in the python package, meaning if you get the package you don't need to have node/npm, run npm i, npm run build, ... Should be prepackaged.
I guess similarly here we can compile and package .po+.json, and people don't have to have all that extra junk (npm / po2json / pybabel / ...). Also doesn't seem good practice (is it even allowed) to mutate the package in place post install. I think you'd be supposed to do this in home somewhere like ~/.superset/ ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org