[GitHub] [hbase] shahrs87 commented on a change in pull request #2908: [HBASE-25536] Remove 0 length wal file from logQueue if it belongs to…

[GitBox <gi...@apache.org>]

shahrs87 commented on a change in pull request #2908:
URL: https://github.com/apache/hbase/pull/2908#discussion_r566378144



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -248,7 +248,7 @@ private void handleEmptyWALEntryBatch() throws InterruptedException {
   // enabled, then dump the log
   private void handleEofException(IOException e) {
     if ((e instanceof EOFException || e.getCause() instanceof EOFException) &&
-      logQueue.size() > 1 && this.eofAutoRecovery) {
+      (source.isRecovered() || logQueue.size() > 1) && this.eofAutoRecovery) {

Review comment:
       > On a related note, should we add a source and global metric counter to track the number of 0 size files dequeued? Seems more common than we thought, easy to monitor may be..
   
   @bharathv  Good idea. Could you please create a separate jira to track this. Thank you !




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org