[GitHub] [maven] sultan commented on pull request #929: [MNG-7559] Fix version comparison (master 4.0.x branch)

[GitBox <gi...@apache.org>]

sultan commented on PR #929:
URL: https://github.com/apache/maven/pull/929#issuecomment-1359689621

   > I must honestly admit that I feel a lot of pain in my ass with this class because:
   > 
   > * There are too many implications
   > * No explicit ordering
   > * No explicit statement/code what is _before_ GA and _after_.
   > 
   > Edge case: `1.0-a` (alpha) < `1.0` < `1.0-abc` since the qualifier `abc` is not an alpha.
   > 
   > I think this needs to be split up again. Let's first focus on the `.` (dot) and `-` (hyphen) issue. From my PoV the PR addresses several issues which does not feel right.
   
   this can be split into two PRs if needed.
   
   the ordering is dispatched into specific locations:
   * private static final List<String> QUALIFIERS = Arrays.asList("snapshot", "", "sp");
   * public static String comparableQualifier(String qualifier)
   * public static int compareQualifiers(String qualifier1, String qualifier2)
   
   but the very fact its separated so far from each other might suggest a different approach


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org